Distinguish why AOT is disabled post-restore - #20241
Merged
Merged
Conversation
Contributor
Author
|
Jenkins test sanity.functional alinux64 jdk11 |
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
dsouzai
force-pushed
the
fixAOTTests
branch
from
September 26, 2024 14:00
34aeb1c to
070e9f2
Compare
Contributor
Author
|
Jenkins test sanity.functional alinux64 jdk11 |
Contributor
Author
|
@ymanton could you review/merge? |
tajila
added this to the
Release 0.48 (Java 8, 11, 17, 21, 23) October refresh milestone
ymanton
reviewed
Sep 27, 2024
ymanton
left a comment
ymanton
left a comment
Member
There was a problem hiding this comment.
LGTM.
I take it this will resolve cases where tests are spuriously failing because of
AOT load and compilation disabled post restore.
will now pass because the output will be
AOT load and compilation disabled pre-checkpoint and post-restore.
?
Member
|
Disregard the above, looked at #20233 and that is indeed what should happen. Why is this only relevant to aarch64? |
Contributor
Author
My guess is that there's some kind of infra or config issue that's preventing the JIT from enabling AOT pre-checkpoint (eg, the SCC can't be validated, or there's no SCC, or whatever). |
dsouzai
removed this from the
Release 0.48 (Java 8, 11, 17, 21, 23) October refresh milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-Restore, the
AOT load and compilation disabled post restore.can be printed out either because AOT was disabled due to options/factors pre-checkpoint or options/factors post-restore. This PR adds a new NLS message to distinguish between these two scenarios.#20233