Skip to content

AArch64 macOS: Enable DDR build - #14420

Merged
pshipton merged 1 commit into
eclipse-openj9:masterfrom
knn-k:aarch64macos7
May 27, 2022
Merged

AArch64 macOS: Enable DDR build#14420
pshipton merged 1 commit into
eclipse-openj9:masterfrom
knn-k:aarch64macos7

Conversation

@knn-k

@knn-k knn-k commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

This commit enables DDR of AArch64 macOS builds.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

@knn-k

knn-k commented Feb 2, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test sanity amac jdk17

@knn-k knn-k mentioned this pull request Feb 3, 2022
Closed
@knn-k

knn-k commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test sanity.system amac jdk17

@knn-k

knn-k commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test sanity.functional,sanity.system amac jdk18

@knn-k

knn-k commented Feb 9, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test extended.system amac jdk17

1 similar comment
@knn-k

knn-k commented Feb 9, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test extended.system amac jdk17

@knn-k

knn-k commented Feb 9, 2022

Copy link
Copy Markdown
Contributor Author

jenkins compile amac jdk11

@knn-k

knn-k commented Feb 25, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test extended.system amac jdk18

@knn-k

knn-k commented Feb 25, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test special.system amac jdk18

@knn-k

knn-k commented Apr 19, 2022

Copy link
Copy Markdown
Contributor Author

This PR depends on eclipse-omr/omr#6471 and #14921.

@knn-k

knn-k commented Apr 19, 2022

Copy link
Copy Markdown
Contributor Author

jenkins compile amac jdk11

@knn-k

knn-k commented Apr 19, 2022

Copy link
Copy Markdown
Contributor Author

jenkins compile amac jdk11

@knn-k

knn-k commented Apr 19, 2022

Copy link
Copy Markdown
Contributor Author

Segmentation faults in dwarfdump-classic and omr_ddrgen. I cannot reproduce this locally.

[2022-04-19T05:51:56.511Z] sh: line 1: 49005 Segmentation fault: 11  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/dwarfdump-classic /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9ddr_misc29.dylib.dSYM/Contents/Resources/DWARF/libj9ddr_misc29.dylib 2>&1
[2022-04-19T05:51:56.512Z] /bin/sh: line 1: 48983 Segmentation fault: 11  /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/omr_ddrgen /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9ddr_misc29.dylib.dSYM/Contents/Resources/DWARF/libj9ddr_misc29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9gc29.dylib.dSYM/Contents/Resources/DWARF/libj9gc29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libjclse29.dylib.dSYM/Contents/Resources/DWARF/libjclse29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9jvmti29.dylib.dSYM/Contents/Resources/DWARF/libj9jvmti29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9prt29.dylib.dSYM/Contents/Resources/DWARF/libj9prt29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9trc29.dylib.dSYM/Contents/Resources/DWARF/libj9trc29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9shr29.dylib.dSYM/Contents/Resources/DWARF/libj9shr29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9thr29.dylib.dSYM/Contents/Resources/DWARF/libj9thr29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9vrb29.dylib.dSYM/Contents/Resources/DWARF/libj9vrb29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libj9vm29.dylib.dSYM/Contents/Resources/DWARF/libj9vm29.dylib /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/libomrsig.dylib.dSYM/Contents/Resources/DWARF/libomrsig.dylib --show-empty --macrolist /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/ddr_info/sets/j9ddr.macros --excludes /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/openj9/runtime/ddr/excludes --blob /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/j9ddr.dat --superset /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/superset.dat --overrides /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/openj9/runtime/ddr/overrides
[2022-04-19T05:51:56.512Z] make[10]: *** [/Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm/runtime/j9ddr.dat] Error 139

@knn-k
knn-k force-pushed the aarch64macos7 branch 2 times, most recently from 27a8fdc to 31933c5 Compare April 21, 2022 03:18
@knn-k

knn-k commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

PRs #14376 and #14427 disabled DDR tests on AArch64 macOS, and this PR enables them back.

@knn-k

knn-k commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

jenkins compile amac jdk17

@knn-k

knn-k commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

I opened an issue for the build failure: eclipse-omr/omr#6491

@knn-k

knn-k commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

jenkins compile amac,xmac jdk17 depends eclipse-omr/omr#5800

This was referenced Apr 25, 2022
Closed
Closed
@knn-k

knn-k commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

I separated the changes for enabling DDR tests to PR #14961.

@knn-k knn-k mentioned this pull request Apr 25, 2022
Merged
@knn-k

knn-k commented May 20, 2022

Copy link
Copy Markdown
Contributor Author

jenkins compile amac,xmac jdk17 depends eclipse-omr/omr#5800

@knn-k

knn-k commented May 20, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test extended.functional xmac jdk17 depends eclipse-omr/omr#5800

@knn-k

knn-k commented May 21, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test sanity amac jdk11 depends eclipse-omr/omr#5800

@knn-k knn-k mentioned this pull request May 25, 2022
Closed
@keithc-ca

keithc-ca commented May 25, 2022

Copy link
Copy Markdown
Contributor

jenkins test sanity osx jdk8,jdk11 depends eclipse-omr/omr#6527

@knn-k

knn-k commented May 26, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test sanity amac jdk11 depends eclipse-omr/omr#6527

@pshipton

pshipton commented May 26, 2022

Copy link
Copy Markdown
Member

The OMR changes are merged and promoted now.

jenkins test sanity amac jdk11

@knn-k
knn-k marked this pull request as ready for review May 26, 2022 13:38
@pshipton

pshipton commented May 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

We should unexclude the ddr tests as part of this PR to enable DDR.

@pshipton

pshipton commented May 26, 2022

Copy link
Copy Markdown
Member

I see re-enabling the tests was moved to #14961, but that means it's not easily PR tested to enable DDR and run the tests to ensure they are working.

@pshipton

pshipton commented May 26, 2022

Copy link
Copy Markdown
Member

jenkins compile amac jdk17,jdk18,jdknext

@knn-k

knn-k commented May 26, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test sanity.functional,extended.functional amac jdk11

I moved the changes from PR #14961 back to this PR.

@knn-k

knn-k commented May 27, 2022

Copy link
Copy Markdown
Contributor Author

You can see the DDR tests in sanity.functional and extended.functional finished successfully.

ibmruntimes/ci-jenkins-pipelines#64 needs to be merged for enabling DDR builds in internal builds.

@knn-k
AArch64 macOS: Enable DDR build
a46596d 
This commit enables DDR of AArch64 macOS builds.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k

knn-k commented May 27, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test sanity amac jdk11

I enabled one more test back, cmdLineTester_GCCheck, which I had overlooked in #14961. The test uses jdmpview.

@pshipton
pshipton merged commit 9a4dd7f into eclipse-openj9:master May 27, 2022
@knn-k
knn-k deleted the aarch64macos7 branch May 27, 2022 12:49
@knn-k

knn-k commented May 29, 2022

Copy link
Copy Markdown
Contributor Author

How about enabling DDR on AArch64 macOS with v0.33.0?

@0xdaryl

0xdaryl commented May 30, 2022

Copy link
Copy Markdown
Contributor

How about enabling DDR on AArch64 macOS with v0.33.0?

What dependent PRs need to be merged into 0.33 since the release split?

@knn-k

knn-k commented May 30, 2022

Copy link
Copy Markdown
Contributor Author

Only the following PRs after the 0.33 split are required:

knn-k added a commit to knn-k/openj9 that referenced this pull request May 30, 2022
@knn-k
(0.33.0) AArch64 macOS: Enable DDR build
e033809 
This commit enables DDR of AArch64 macOS builds.
It also enables related testcases.

Original PR in master: eclipse-openj9#14420

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k knn-k mentioned this pull request May 30, 2022
Merged
@knn-k

knn-k commented May 30, 2022

Copy link
Copy Markdown
Contributor Author

I opened the following PRs for 0.33.

@keithc-ca keithc-ca mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pshipton pshipton pshipton approved these changes

Assignees

No one assigned

Labels

arch:aarch64 comp:build comp:vm os:macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@knn-k @keithc-ca @pshipton @0xdaryl