Set flavor and count in AArch64 macOS core file - #6471
Merged
Conversation
This commit adds code for setting "flavor" and "count" in the thread commands in the core files on AArch64 macOS. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
Contributor
Author
|
|
Contributor
Author
|
I am not making changes to the code for x86 in this PR. macOS data structures seem to be different between x86 and AArch64. |
Contributor
Author
|
@keithc-ca Could you take a look at this, please? Thanks. |
keithc-ca
approved these changes
Apr 19, 2022
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
This looks reasonable to me based on the comments, including the otool output.
0xdaryl
approved these changes
Apr 19, 2022
Contributor
|
Jenkins build osx,aarch64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds code for setting "flavor" and "count" in the thread
commands in the core files on AArch64 macOS.
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com