Skip to content

[MODEL] Implement plamo3 - #28834

Merged
vllm-bot merged 6 commits into
vllm-project:mainfrom
pfnet:implement-plamo3
Nov 20, 2025
Merged

vllm-bot merged 6 commits into
vllm-project:mainfrom
pfnet:implement-plamo3

Conversation

@Alnusjaponica

@Alnusjaponica Alnusjaponica commented Nov 17, 2025 •

Copy link
Copy Markdown
Contributor

Purpose

This PR adds support for PLaMo3 falimies.

Test Plan

Run unit test added to tests/distributed/test_pipeline_parallel.py

Test Result

> uv run pytest tests/distributed/test_pipeline_parallel.py
/usr/local/lib/python3.12/dist-packages/pytest_asyncio/plugin.py:211: PytestDeprecationWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset.
The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous fixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "class", "module", "package", "session"

  warnings.warn(PytestDeprecationWarning(_DEFAULT_FIXTURE_LOOP_SCOPE_UNSET))
=================================== test session starts ====================================
platform linux -- Python 3.12.3, pytest-8.3.5, pluggy-1.5.0
rootdir: /home/team-prj-mfm-platform/pfnet-vllm
configfile: pyproject.toml
plugins: hydra-core-1.3.2, Faker-37.6.0, asyncio-1.1.0, typeguard-4.4.2, anyio-4.9.0
asyncio: mode=Mode.STRICT, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 3 items                                                                          

tests/distributed/test_pipeline_parallel.py .ss                                      [100%]

===================================== warnings summary =====================================
tests/distributed/test_pipeline_parallel.py::test_tp_language_generation[pfnet/plamo-3-nict-2b-base-parallel_setup0-mp-auto-test_options0]
  /home/team-prj-mfm-platform/pfnet-vllm/tests/utils.py:890: DeprecationWarning: This process (pid=2490685) is multi-threaded, use of fork() may lead to deadlocks in the child.
    pid = os.fork()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=================== 1 passed, 2 skipped, 1 warning in 121.31s (0:02:01) ====================

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
@mergify

mergify Bot commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--28834.org.readthedocs.build/en/28834/

@mergify mergify Bot added documentation Improvements or additions to documentation new-model Requests to new models labels Nov 17, 2025
@Alnusjaponica
Alnusjaponica marked this pull request as ready for review November 18, 2025 06:50
@Alnusjaponica

Alnusjaponica commented Nov 18, 2025 •

Copy link
Copy Markdown
Contributor Author

@DarkLight1337 @ywang96 @youkaichao

Hi, we’ve published our new model family PLaMo3, and I’ve added vLLM support in this PR. Could anyone kindly take a look at this PR?

Also, I have a couple of questions:

  • Since PLaMo3 models are gated, I assume CI will need access. What’s the best way to handle that?
  • I didn’t see a v0.11.1 section in the release notes draft — should I create one, or is there another place to note these changes?

Comment thread tests/models/registry.py Resolved
Comment thread vllm/model_executor/models/plamo3.py Resolved
@DarkLight1337

Copy link
Copy Markdown
Member

I didn’t see a v0.11.1 section

Feel free to add a new section!

Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
@Alnusjaponica

Copy link
Copy Markdown
Contributor Author

Feel free to add a new section!

Thanks! I have updated the draft.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 19, 2025

@DarkLight1337 DarkLight1337 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass so this should be good to go, thanks!

@vllm-bot
vllm-bot merged commit c9e0931 into vllm-project:main Nov 20, 2025
47 of 48 checks passed
@Alnusjaponica
Alnusjaponica deleted the implement-plamo3 branch November 20, 2025 11:25
RunkaiTao pushed a commit to RunkaiTao/vllm that referenced this pull request Nov 24, 2025
Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
Signed-off-by: Runkai Tao <rt572@physics.rutgers.edu>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: Shinichi Hemmi <50256998+Alnusjaponica@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation new-model Requests to new models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants