Skip to content

[Misc] Fix some help info of arg_utils to improve readability - #10362

Merged
DarkLight1337 merged 2 commits into
vllm-project:mainfrom
ShangmingCai:fix_arg_utils_typos
Nov 15, 2024
Merged

DarkLight1337 merged 2 commits into
vllm-project:mainfrom
ShangmingCai:fix_arg_utils_typos

Conversation

@ShangmingCai

Copy link
Copy Markdown
Contributor

I have noticed some formatting issues in the help info of arg_utils. Specifically, some cases exist where words are connected without spaces when the text wraps to a new line.

For example,

parser.add_argument(
            '--num-gpu-blocks-override',
            type=int,
            default=None,
            help='If specified, ignore GPU profiling result and use this number'
            'of GPU blocks. Used for testing preemption.')
image So I fix all I can find.

cc @DarkLight1337

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the QoL improvement!

@DarkLight1337
DarkLight1337 enabled auto-merge (squash) November 15, 2024 09:52
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 15, 2024
@DarkLight1337
DarkLight1337 merged commit f2056f7 into vllm-project:main Nov 15, 2024
@ShangmingCai
ShangmingCai deleted the fix_arg_utils_typos branch November 18, 2024 03:02
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants