Repository navigation
[Doc] Remove float32 choice from --lora-dtype - #10348
Merged
Merged
Conversation
Signed-off-by: Xin Yang <xyang19@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
DarkLight1337
approved these changes
Nov 15, 2024
DarkLight1337
left a comment
Member
There was a problem hiding this comment.
Thanks for removing this confusing bit!
DarkLight1337
enabled auto-merge (squash)
November 15, 2024 04:29
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Xin Yang <xyang19@gmail.com>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
Signed-off-by: Xin Yang <xyang19@gmail.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Xin Yang <xyang19@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove float32 choice from --lora-dtype because float32 is not really supported.
I ran the command below following https://github.com/vllm-project/vllm/blob/main/docs/source/models/lora.rst:
Got the error below because of AssertionError: https://github.com/vllm-project/vllm/blob/main/vllm/lora/ops/sgmv_expand.py#L133-L136