Repository navigation
Conversation
Move connection cleanup into a finally block so the connection is closed even if commit or auto-commit restoration fails. Closes spring-projectsgh-37321 Signed-off-by: cookie-meringue <daehyeon3351@gmail.com>
sbrannen
force-pushed
the
fix-connection-leak-in-mysql-incrementer
branch
from
October 3, 2026 16:35
8cf7dfc to
a75ee00
Compare
Contributor
|
Fixed via 5e45b9b |
Member
|
This has been merged into Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
useNewConnectionistrue(the default),MySQLMaxValueIncrementerobtains a separate connection to update the sequence value.If auto-commit is enabled on that connection, it temporarily disables it, commits the update, and then re-enables it to restore the original setting.
If
commit()or the subsequentsetAutoCommit(true)call throws anSQLException, the exception handler throws aDataAccessResourceFailureExceptionbefore reachingConnection.close().This can leave the connection unreleased.
Move
JdbcUtils.closeConnection(con)into afinallyblock so cleanup is attempted even when commit or auto-commit restoration fails.