Skip to content

[AIR/Data] Make Preprocessor.transform lazy by default - #32872

Merged
amogkam merged 8 commits into
ray-project:masterfrom
amogkam:preprocessor-lazy
Feb 28, 2023
Merged

[AIR/Data] Make Preprocessor.transform lazy by default#32872
amogkam merged 8 commits into
ray-project:masterfrom
amogkam:preprocessor-lazy

Conversation

@amogkam

@amogkam amogkam commented Feb 27, 2023

Copy link
Copy Markdown
Contributor

Change Preprocessor.transform to be lazy by default, aligning with the default execution pattern for Datasets. This allows preprocessors to be used in either training or inference pipelines in a streaming fashion.

This PR also deprecates Preprocessor.transform_stats. Stats can now be accessed directly from the Dataset after execution.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>

@bveeramani bveeramani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 27, 2023

@c21 c21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
@amogkam amogkam removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 28, 2023
@amogkam
amogkam merged commit 192a261 into ray-project:master Feb 28, 2023
@amogkam
amogkam deleted the preprocessor-lazy branch February 28, 2023 18:59
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
â€Ķ#32872)

Change Preprocessor.transform to be lazy by default, aligning with the default execution pattern for Datasets. This allows preprocessors to be used in either training or inference pipelines in a streaming fashion.

This PR also deprecates Preprocessor.transform_stats. Stats can now be accessed directly from the Dataset after execution.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
â€Ķ#32872)

Change Preprocessor.transform to be lazy by default, aligning with the default execution pattern for Datasets. This allows preprocessors to be used in either training or inference pipelines in a streaming fashion.

This PR also deprecates Preprocessor.transform_stats. Stats can now be accessed directly from the Dataset after execution.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
â€Ķ#32872)

Change Preprocessor.transform to be lazy by default, aligning with the default execution pattern for Datasets. This allows preprocessors to be used in either training or inference pipelines in a streaming fashion.

This PR also deprecates Preprocessor.transform_stats. Stats can now be accessed directly from the Dataset after execution.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
â€Ķ#32872)

Change Preprocessor.transform to be lazy by default, aligning with the default execution pattern for Datasets. This allows preprocessors to be used in either training or inference pipelines in a streaming fashion.

This PR also deprecates Preprocessor.transform_stats. Stats can now be accessed directly from the Dataset after execution.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
â€Ķ#32872)

Change Preprocessor.transform to be lazy by default, aligning with the default execution pattern for Datasets. This allows preprocessors to be used in either training or inference pipelines in a streaming fashion.

This PR also deprecates Preprocessor.transform_stats. Stats can now be accessed directly from the Dataset after execution.

---------

Signed-off-by: amogkam <amogkamsetty@yahoo.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants