Skip the root application artifact and clear the reloadable flag properly when processing deployment dependencies - #49512
Merged
gsmet merged 1 commit intoAug 14, 2025
Conversation
…erly when processing deployment dependencies
Status for workflow
|
gsmet
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue that appears when using test fixtures but in some particular situations. I wasn't able to create a minimal reproducer that creates that particular situation in a dependency graph.
The change is about skipping processing the root application artifact in case it appears among the dependencies (deployment in particular) and properly passing reloadable flag to the children of a processed dependency.
Fixes #49462, #49463, #49464