Skip to content

SLHDSA ACVP tests - #2237

Merged
dstebila merged 4 commits into
open-quantum-safe:mainfrom
h2parson:slh_acvp
Aug 27, 2025
Merged

SLHDSA ACVP tests#2237
dstebila merged 4 commits into
open-quantum-safe:mainfrom
h2parson:slh_acvp

Conversation

@h2parson

Copy link
Copy Markdown
Contributor

This PR adds ACVP tests for SLH DSA

This does not address any issue.

The ACVP tests are sourced from NIST and have been run. All passed.

This PR does not change the behaviour of algorithms or the list of algorithms available.

Please note that this pull request will need to be merged AFTER slhdsa has been integrated into libOQS.

Signed-off-by: h2parson <h2parson@uwaterloo.ca>
Signed-off-by: h2parson <h2parson@uwaterloo.ca>
Signed-off-by: h2parson <h2parson@uwaterloo.ca>
@h2parson
h2parson marked this pull request as ready for review August 19, 2025 17:36
Comment thread tests/vectors_sig.c Outdated
Signed-off-by: Douglas Stebila <dstebila@users.noreply.github.com>
@dstebila dstebila added the needs review Looking for a(nother) review label Aug 20, 2025
@dstebila
dstebila requested a review from a team August 20, 2025 14:28
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 82.968% (+0.2%) from 82.755%
when pulling bbb175d on h2parson:slh_acvp
into 01de36c on open-quantum-safe:main.

@bhess bhess left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dstebila
dstebila merged commit cbffa33 into open-quantum-safe:main Aug 27, 2025
2 checks passed
@bhess bhess mentioned this pull request Sep 24, 2025
2 tasks
@xuganyu96 xuganyu96 added this to the 0.15.0 milestone Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Looking for a(nother) review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants