Skip to content

fix bug of change_accelerator - #1819

Merged
Myhs-phz merged 3 commits into
open-compass:mainfrom
zhangzefeng92:main
Oct 10, 2026
Merged

Myhs-phz merged 3 commits into
open-compass:mainfrom
zhangzefeng92:main

Conversation

@zhangzefeng92

Copy link
Copy Markdown
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

æĻĄåž‹įąŧ型äļšopencompass.models.huggingface_above_v4_33.HuggingFaceBaseModelæ—ķ--accelerator参数äļčƒ―æ­ĢįĄŪåŊį”Ļvllm加速。

Modification

į”ąäšŽf'{HuggingFaceBaseModel.__module__}.{HuggingFaceBaseModel.__name__}'įš„įąŧ型äļšå­—įŽĶäļēïžŒč€Œmodel['type']åš”čŊĨäļšclass因æ­Īäļ‹éĒįš„äŧĢ᠁äļčƒ―æ­ĢįĄŪæ ĄéŠŒæĻĄåž‹įš„įąŧ型。åŊđčŊĨ文äŧķäļ­įš„bugčŋ›čĄŒäŋŪåĪã€‚

if model['type'] in [HuggingFace, HuggingFaceCausalLM, HuggingFaceChatGLM3, eval(f'{HuggingFaceBaseModel.__module__}.{HuggingFaceBaseModel.__name__}')]:

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • [ x ] Pre-commit or other linting tools are used to fix the potential lint issues.
  • [ x ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [ x ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [ x ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • [ x ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • [ x ] CLA has been signed and all committers have signed the CLA in this PR.

@Myhs-phz
Myhs-phz merged commit 7c6ab68 into open-compass:main Oct 10, 2026
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants