Remove typings.json files in favour of @types/ packages - #21700
Merged
Jamie Magee (JamieMagee) merged 1 commit intoJan 20, 2026
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Jamie Magee (JamieMagee)
force-pushed
the
users/jamagee/remove-typings-json
branch
from
January 13, 2026 17:18
10f2011 to
b5e45a0
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Jamie Magee (JamieMagee)
force-pushed
the
users/jamagee/remove-typings-json
branch
from
January 13, 2026 18:19
b5e45a0 to
10b5136
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Jamie Magee (JamieMagee)
force-pushed
the
users/jamagee/remove-typings-json
branch
from
January 13, 2026 18:37
10b5136 to
3efec1b
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Jamie Magee (JamieMagee)
force-pushed
the
users/jamagee/remove-typings-json
branch
from
January 16, 2026 05:13
3efec1b to
30ec8d7
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Tarun Ramsinghani (tarunramsinghani)
approved these changes
Jan 16, 2026
Jamie Magee (JamieMagee)
enabled auto-merge (squash)
January 16, 2026 16:07
Lukas Cenovsky (lucen-ms)
approved these changes
Jan 16, 2026
Lukas Cenovsky (lucen-ms)
left a comment
Lukas Cenovsky (lucen-ms)
left a comment
Contributor
There was a problem hiding this comment.
approved for AppCenterTestV1
Evgenii Dergachev (DergachevE)
approved these changes
Jan 16, 2026
Razvan Manole (manolerazvan)
approved these changes
Jan 19, 2026
Vinayak (vinayakmsft)
approved these changes
Jan 20, 2026
Vinayak (vinayakmsft)
left a comment
Vinayak (vinayakmsft)
left a comment
Contributor
There was a problem hiding this comment.
approved for VstestV2 and V3
Virender Kumar (virekumar)
left a comment
Virender Kumar (virekumar)
left a comment
Contributor
There was a problem hiding this comment.
I did check code changes for VsTestV2 and VsTestV3 task.
| Activity | VsTestV3 | VsTestV3 |
|---|---|---|
| Build | Passed | Passed |
| Tests | Passed | Passed |
| Deployment Success | Success | Success |
| Task deployed in test org | Working | Working |
| Tests publish in Test tab | Success | Success |
| Any anomaly detected | No | No |
Approving based on above analysis
Virender Kumar (virekumar)
approved these changes
Jan 20, 2026
The typings package was deprecated with the release of TypeScript 2.0 in 2016. Types are now provided via @types/ packages from DefinitelyTyped. Changes: - Remove typings.json from AndroidSigningV2, AndroidSigningV3, AppCenterTestV1, DownloadBuildArtifactsV0, JenkinsDownloadArtifactsV1, JenkinsDownloadArtifactsV2, ReviewAppV0, VsTestV2, and VsTestV3 tasks - Remove the entire typings/ directory from AppCenterTestV1 (contained old type definitions for node, q, mocha, glob, form-data, and request) - Add @types/q to JenkinsDownloadArtifactsV1 and JenkinsDownloadArtifactsV2 package.json since these tasks use the q promise library Most tasks already had the required @types/ packages in their dependencies: - @types/node, @types/mocha, @types/q, @types/uuid as needed Fixes #18761
Jamie Magee (JamieMagee)
force-pushed
the
users/jamagee/remove-typings-json
branch
from
January 20, 2026 15:11
30ec8d7 to
4e45024
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Jamie Magee (JamieMagee)
deleted the
users/jamagee/remove-typings-json
branch
January 20, 2026 16:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The typings package was an early approach for the TypeScript community to add types to npm packages that don't provide them. It was deprecated with the release of TypeScript 2.0 in 2016, and types are now found in
@types/packages from DefinitelyTyped.Fixes #18761
Task Name
Description
typings.jsonfrom all 9 affected taskstypings/directory from AppCenterTestV1 (contained old type definitions for node, q, mocha, glob, form-data, and request)@types/qto JenkinsDownloadArtifactsV1 and JenkinsDownloadArtifactsV2package.jsonsince these tasks use the q promise libraryMost tasks already had the required
@types/packages in their dependencies (@types/node,@types/mocha,@types/q,@types/uuidas needed).Risk Assessment (Low / Medium / High)
Low - This is a build-time only change. The
typings.jsonfiles andtypings/directories are not used at runtime and were already superseded by the@types/packages inpackage.json. No functional changes to task behavior.Change Behind Feature Flag (Yes / No)
No - This is a cleanup of deprecated build tooling, not a feature change.
Tech Design / Approach
@types/packages from DefinitelyTyped are the standard approach for TypeScript type definitions since TypeScript 2.0 (2016).Documentation Changes Required (Yes/No)
No - No user-facing documentation changes required.
Unit Tests Added or Updated (Yes / No)
No - No test changes required. This change only removes deprecated type definition files that were not being used.
Additional Testing Performed
typings.jsonfiles have been removedtypings/directory in AppCenterTestV1 has been removed@types/packages in theirpackage.jsonLogging Added/Updated (Yes/No)
No - No logging changes required for this cleanup.
Telemetry Added/Updated (Yes/No)
No - No telemetry changes required for this cleanup.
Rollback Scenario and Process (Yes/No)
Yes - Simple revert of the commit if needed. No data migrations or external dependencies affected.
Dependency Impact Assessed and Regression Tested (Yes/No)
Yes - All affected tasks already have the required
@types/packages in theirpackage.json. The removedtypings.jsonfiles were legacy and not actively used by the TypeScript compiler.Checklist