Repository navigation
chore(triage): migrate automation from theme/* to pillar/* labels - #3636
Daniel Meppiel (danielmeppiel) merged 4 commits into
Conversation
Triage now classifies with the roadmap pillar/* labels (consume, produce, govern, ecosystem, foundations). Mapping for legacy content: portability -> consume, governance -> govern, security -> govern. - label-contract.json (all 8 copies): pillar/* allowlist; the legacy `security` read alias maps to pillar/govern. - triage_state.py: pillar is the single-valued classification dimension. - triage-panel.md add-labels allowlist; lock recompiled with gh-aw v0.89.15. - Triage worker prose/templates, autopilot README, maintainer canvas label chips, and the contributor-dashboard fixture. - apm.lock.yaml: only the changed deployed-file and package hashes. - Regression tests: pillar conflicts fail closed; no tracked file names the retired label family. Refs #3634 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
ðĒ Approval recommended
The review reports no active issues with the pillar-based triage migration.
No open issues ð
What changed in this PR
Updates APMâs issue and PR triage automation to use roadmap pillar/* labels, implementing the code portion of #3634. Live-label backfill and deletion remain a separate maintainer decision.
Changes:
- Replaces legacy classification allowlists with five pillars and updates planners to reject conflicting pillar proposals.
- Synchronizes workflow output permissions, worker guidance, installed copies, lock hashes, and canvas badges while preserving the
classification.themepayload key. - Adds migration regression tests, updates the dashboard fixture, and records the change in the changelog.
| File | Description |
|---|---|
tests/âunit/âtest_triage_advisory.py |
Adds pillar-conflict, alias, allowlist, and retired-reference checks. |
packages/âautopilot/âREADME.md |
Documents pillar-based classification. |
packages/âautopilot/âautopilot-pr-triage-worker/â.apm/âskills/âautopilot-pr-triage-worker/âassets/âpr-triage-template.md |
Updates PR advice terminology to pillars. |
packages/âautopilot/âautopilot-pr-triage-worker/â.apm/âskills/âautopilot-pr-triage-worker/âassets/âlabel-contract.json |
Updates PR worker labels and the security alias. |
packages/âautopilot/âautopilot-pr-triage-scheduler/â.apm/âskills/âautopilot-pr-triage-scheduler/âscripts/âtriage_state.py |
Rejects conflicting PR pillar additions. |
packages/âautopilot/âautopilot-pr-triage-scheduler/â.apm/âskills/âautopilot-pr-triage-scheduler/âassets/âlabel-contract.json |
Updates PR scheduler labels and the security alias. |
packages/âautopilot/âautopilot-maintainer-canvas/â.apm/âextensions/âautopilot-maintainer/âui.mjs |
Displays pillar badges instead of theme badges. |
packages/âautopilot/âautopilot-issue-triage-worker/âSKILL.md |
Defines pillar guidance and preserves payload compatibility. |
packages/âautopilot/âautopilot-issue-triage-worker/âassets/âtriage-template.md |
Updates issue advice terminology to pillars. |
packages/âautopilot/âautopilot-issue-triage-worker/âassets/âlabel-contract.json |
Updates issue worker labels and the security alias. |
packages/âautopilot/âautopilot-issue-triage-scheduler/â.apm/âskills/âautopilot-issue-triage-scheduler/âscripts/âtriage_state.py |
Rejects conflicting issue pillar additions. |
packages/âautopilot/âautopilot-issue-triage-scheduler/â.apm/âskills/âautopilot-issue-triage-scheduler/âassets/âlabel-contract.json |
Updates issue scheduler labels and the security alias. |
packages/âapm-contributor-dashboard/âtests/âserver.test.mjs |
Uses a pillar value in the legacy payload fixture. |
CHANGELOG.md |
Records the triage taxonomy migration. |
apm.lock.yaml |
Refreshes affected package and deployed-file hashes. |
.github/âworkflows/âtriage-panel.md |
Updates permitted output labels and occupied-dimension guidance. |
.github/âworkflows/âtriage-panel.lock.yml |
Synchronizes compiled allowlists and workflow metadata. |
.agents/âskills/âautopilot-pr-triage-worker/âassets/âpr-triage-template.md |
Synchronizes the installed PR advice template. |
.agents/âskills/âautopilot-pr-triage-worker/âassets/âlabel-contract.json |
Synchronizes the installed PR worker contract. |
.agents/âskills/âautopilot-pr-triage-scheduler/âscripts/âtriage_state.py |
Synchronizes installed PR pillar-conflict enforcement. |
.agents/âskills/âautopilot-pr-triage-scheduler/âassets/âlabel-contract.json |
Synchronizes the installed PR scheduler contract. |
.agents/âskills/âautopilot-issue-triage-worker/âSKILL.md |
Synchronizes installed pillar and payload guidance. |
.agents/âskills/âautopilot-issue-triage-worker/âassets/âtriage-template.md |
Synchronizes the installed issue advice template. |
.agents/âskills/âautopilot-issue-triage-worker/âassets/âlabel-contract.json |
Synchronizes the installed issue worker contract. |
.agents/âskills/âautopilot-issue-triage-scheduler/âscripts/âtriage_state.py |
Synchronizes installed issue pillar-conflict enforcement. |
.agents/âskills/âautopilot-issue-triage-scheduler/âassets/âlabel-contract.json |
Synchronizes the installed issue scheduler contract. |
Review effort: Balanced
Pillar is now a single-valued classification dimension: the planner raises on a second proposed pillar and the workflow never adds a label to an occupied dimension. "Primary" was carried over from the theme wording and implied secondary pillars were allowed. Updates the package source, the installed copy, and the two lockfile hashes it moves. Addresses doc-writer panel follow-up on packages/autopilot/autopilot-issue-triage-worker/SKILL.md:288. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
APM Review Panel:
|
| Persona | B | R | N | Takeaway |
|---|---|---|---|---|
| Doc Writer | 0 | 0 | 0 | Fold a1d2090 resolves the "primary pillar" finding; "five-axis taxonomy" matches the canonical contract wording; no new issues. |
B = blocking-severity findings, R = recommended, N = nits.
Counts are signal strength, not gates. The maintainer ships.
Top 2 follow-ups
- [APM CEO] Delete the
theme/portability,theme/governanceandtheme/securitylabel definitions after merge -- the last done-when item of Migrate automation from theme/* to pillar/* labels #3634; six open PRs still carry theme/* and deletion strips them, so it cannot happen before merge. - [APM CEO] Rename payload key
classification.themetoclassification.pillarin a future bounded change -- it is a schema_version 2 contract surface read by the dashboard compiled client.
Recommendation
Fold-complete with zero open panel findings. Ship once the required human review is granted; delete the theme/* labels right after merge and open a bounded issue for the key rename when the next schema version is planned.
Folded in this run
- (panel) doc-writer: "one primary pillar" -> "one pillar" in the triage worker SKILL (package source and installed copy) plus the two lockfile hashes it moves -- resolved in a1d2090.
- (merge) origin/main 1a37071 merged into the branch with no conflicts -- resolved in b753ffd.
Copilot signals reviewed
- Copilot review on 1a80e2d recommended approval with zero inline comments; a second fetch after the fold found no new comments. Nothing to classify.
Deferred (out-of-scope follow-ups)
- (panel) Delete the three theme/* label definitions -- scope boundary: repository label administration that must follow the merge (6 open PRs still carry theme/*); a landing action, not a diff change.
- (panel) Rename payload key
classification.theme->classification.pillar-- scope boundary: changes the schema_version 2 recommendation contract and the dashboard compiled client; not a label reference.
Regression-trap evidence (mutation-break gate)
tests/unit/test_triage_advisory.py::test_pillar_is_a_single_valued_classification_dimension-- reverted planner dimensions to("type", "theme"); test FAILED as expected; guard restored.tests/unit/test_triage_advisory.py::test_automation_classifies_with_pillar_labels_only-- appended a retired-family label line topackages/autopilot/README.md; test FAILED as expected; file restored.
Lint contract
ruff check and ruff format --check (CI path list, ruff 0.15.12), pylint R0801, scripts/lint-auth-signals.sh and scripts/lint-architecture-boundaries.sh all silent on the merged head. Targeted tests: tests/unit/test_triage_advisory.py, test_triage_panel_lock.py, test_triage_fetch_queue.py 78 passed; dashboard node tests 167/167; maintainer canvas node tests 45/45.
CI
All checks pass at a1d2090 (CI run 43261260257: Lint, Build & Test shards 1-2, Lifecycle Smoke shards 1-2, Windows Compatibility Gate, Windows Native Symlink Acceptance, Architecture Ratchets, PR Binary Smoke; CodeQL 43261260198; Merge Gate gate; NOTICE Drift; license/cla pass) (after 0 CI fix iterations).
Mergeability status
| PR | head SHA | CEO stance | iters | folds | defers | Copilot rounds | CI | mergeable | mergeStateStatus | notes |
|---|---|---|---|---|---|---|---|---|---|---|
| #3636 | a1d2090 |
ship_with_followups | 1 | 1 | 2 | 2 | green | MERGEABLE | BLOCKED | awaiting required review |
Convergence
1 outer iteration; 2 Copilot rounds. Final panel stance: ship_with_followups. Closes #3634 on merge; the post-merge label deletion above is the remaining done-when item. Ready for maintainer review.
Full per-persona findings
Doc Writer
No findings (delta). Lean pass finding, now folded: [recommended] SKILL.md said "one primary pillar" but the planner rejects any second pillar, at packages/autopilot/autopilot-issue-triage-worker/SKILL.md:288. Resolved in a1d2090.
Supply Chain Security Expert (lean pass)
No findings.
This panel is advisory. It does not block merge. Re-apply the
panel-review label after addressing feedback to re-run.
Generated by autopilot-pr-merge-worker. This comment is AI-generated and may contain errors.
Keep #3636's theme/* -> pillar/* migration and this PR's contract repairs. apm.lock.yaml: main's lock with only the four touched packages' records and the two check_required_agents.py deployments refreshed; apm audit --ci passes with no drift. Co-authored-by: sergio-sisternes-epam <sergio-sisternes-epam@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Description
TL;DR. Triage automation now classifies with the roadmap
pillar/*labels (consume, produce, govern, ecosystem, foundations) instead of the legacytheme/*family. The label contract, planner, gh-aw workflow allowlist (lock recompiled), worker prose, maintainer canvas, and dashboard fixture all move together, and a regression test keepstheme/out of every tracked file. Open issues were backfilled on GitHub per the coordinator rule; only deleting the threetheme/*label definitions remains, after merge.Fixes #3634
Important
Local preflight skipped by maintainer instruction (2026-11-12); CI is the gate.
Problem (WHY)
2026-11-12-roadmap-taxonomy) replaced the Theme field with five pillars, but triage still allowlisted and appliedtheme/governance|portability|security, so both families kept coexisting on new issues.triage_state.pyenforced "at most one" only fortype/andtheme/; with pillars in the allowlist nothing stopped two conflictingpillar/*proposals.triage-panelsafe-output allowlist is a literal mirror of the contract; it had to move in the same change ortest_triage_panel_lock.pyparity breaks.Approach (WHAT)
label-contract.json(8 identical copies)classification_labels: threetheme/*-> fivepillar/*; legacy read aliassecurity->pillar/governtriage_state.py(4 copies)("type", "pillar").github/workflows/triage-panel.md+.lock.ymlpillar/; lock recompiled with the recorded compiler gh-aw v0.89.15SKILL.md, templates,packages/autopilot/README.mdclassification.themenow carries thepillar/*valueui.mjspillar/(CSS classlabel-pillar)server.test.mjspillar/governapm.lock.yamlcontent_hashvaluestests/unit/test_triage_advisory.pyImplementation (HOW)
The contract is the canonical owner (the workflow header says so); every other surface is a mirror. Package sources under
packages/autopilot/were edited,.agents/skills/copies were regenerated withapm install, and the lockfile was then restored and patched surgically withcompute_file_hash/compute_local_package_hash-- the same functions the snapshot tests use -- because a fullapm installwith the local CLI rewrote 1500 unrelated lockfile lines (apm_version, licenses).The diagram shows how the contract fans out to each consumer; dashed nodes are the sources this PR edits.
flowchart LR C["label-contract.json<br/>canonical owner"]:::new C -->|"allowlist + aliases"| P["triage_state.py<br/>pillar dimension"]:::new C -->|"literal mirror"| W["triage-panel.md<br/>add-labels allowlist"]:::new W -->|"gh aw compile v0.89.15"| L["triage-panel.lock.yml"] C -->|"apm install"| A[".agents/skills copies<br/>+ apm.lock.yaml hashes"] P --> G{"labels on issue"} L --> G classDef new stroke-dasharray: 5 5Trade-offs
classification.theme. Renaming it topillarwould change the schema_version 2 recommendation contract and the dashboard's compiled client (dist/). The worker SKILL now states the key carries thepillar/*value. A key rename can follow as its own bounded change."theme" + "/"so the repo-wide grep it enforces stays empty, including the test itself.Benefits
git grep -F 'theme/'returns nothing (exit 1) on this branch.Conflicting proposed pillar) instead of applying both.securitylabel now occupies the pillar dimension, so triage does not add a second pillar on top of it.Label backfill (done 2026-11-12)
Rule (coordinator decision by Daniel Meppiel (@danielmeppiel), relayed by Lane G): an issue that already carries a
pillar/*keeps it and only drops itstheme/*; an issue without a pillar gets the mapped one (portability -> consume, governance/security -> govern). Never two pillars.theme/*theme/*removedpillar/consume)theme/*pillar/*(whole repo)Note
Post-merge (Lane L / coordinator): delete the
theme/portability,theme/governanceandtheme/securitylabel definitions only after this PR merges. 6 open PRs (#2030, #2602, #2637, #2933, #3105, #3367) still carrytheme/*and no pillar; deleting the definitions removes those labels. PRs were left untouched.Issue and approved scope
Issue: Fixes #3634
Human scope-approval comment: #3634 (comment) (
eligibility.cjsfrom trustedorigin/main90e76bf:record-present, approver and review contact Daniel Meppiel (@danielmeppiel); fresh confirmation relayed by the Lane G delivery session on 2026-11-12).Does this PR complete the issue, or what remains? It completes the issue except deleting the three
theme/*label definitions, which happens after merge (see the post-merge note).Type of change
Testing
Scenario evidence
securityalias blocks anothertests/unit/test_triage_advisory.py::test_pillar_is_a_single_valued_classification_dimensiontests/unit/test_triage_advisory.py::test_automation_classifies_with_pillar_labels_onlytests/unit/test_triage_panel_lock.py(existing)tests/unit/test_triage_advisory.py::test_local_package_snapshots_match_lockfile(existing)Mutation-break: reverting the planner to
("type", "theme")fails the first test; appending atheme/securityline topackages/autopilot/README.mdfails the second. Both pass after restore.Validation output
How to test
git grep -n -F 'theme/'returns nothing.uv run --extra dev pytest tests/unit/test_triage_advisory.py tests/unit/test_triage_panel_lock.py -qgrep -c pillar/ .github/workflows/triage-panel.lock.ymlshows the allowlist entries.pillar/*label.Spec conformance (OpenAPM v0.1)
docs/src/content/docs/specs/openapm-v0.1.mdupdated(new/changed
<a id="req-XXX"></a>anchor + prose + Appendix Crow).
docs/src/content/docs/specs/manifests/openapm-v0.1.requirements.ymlupdated.
@pytest.mark.req("req-XXX")test undertests/spec_conformance/added or extended.CONFORMANCE.{md,json}regenerated viauv run --extra dev python -m tests.spec_conformance.gen_statementand committed.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com