Skip to content

chore(triage): migrate automation from theme/* to pillar/* labels - #3636

Merged
Daniel Meppiel (danielmeppiel) merged 4 commits into
mainfrom
danielmeppiel-migrate-theme-to-pillar-labels
Nov 12, 2026
Merged

Daniel Meppiel (danielmeppiel) merged 4 commits into
mainfrom
danielmeppiel-migrate-theme-to-pillar-labels

Conversation

@danielmeppiel

@danielmeppiel Daniel Meppiel (danielmeppiel) commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Description

TL;DR. Triage automation now classifies with the roadmap pillar/* labels (consume, produce, govern, ecosystem, foundations) instead of the legacy theme/* family. The label contract, planner, gh-aw workflow allowlist (lock recompiled), worker prose, maintainer canvas, and dashboard fixture all move together, and a regression test keeps theme/ out of every tracked file. Open issues were backfilled on GitHub per the coordinator rule; only deleting the three theme/* label definitions remains, after merge.

Fixes #3634

Important

Local preflight skipped by maintainer instruction (2026-11-12); CI is the gate.

Problem (WHY)

  • The roadmap taxonomy (Atlas decision 2026-11-12-roadmap-taxonomy) replaced the Theme field with five pillars, but triage still allowlisted and applied theme/governance|portability|security, so both families kept coexisting on new issues.
  • triage_state.py enforced "at most one" only for type/ and theme/; with pillars in the allowlist nothing stopped two conflicting pillar/* proposals.
  • The triage-panel safe-output allowlist is a literal mirror of the contract; it had to move in the same change or test_triage_panel_lock.py parity breaks.

Approach (WHAT)

Surface Change
label-contract.json (8 identical copies) classification_labels: three theme/* -> five pillar/*; legacy read alias security -> pillar/govern
triage_state.py (4 copies) single-valued dimensions are now ("type", "pillar")
.github/workflows/triage-panel.md + .lock.yml add-labels allowlist and dimension prose use pillar/; lock recompiled with the recorded compiler gh-aw v0.89.15
Triage worker SKILL.md, templates, packages/autopilot/README.md prose says type/area/pillar; documents that payload key classification.theme now carries the pillar/* value
Maintainer canvas ui.mjs label chips filter pillar/ (CSS class label-pillar)
Contributor dashboard server.test.mjs legacy fixture value pillar/govern
apm.lock.yaml only the 9 changed deployed-file hashes (both sections) and 4 package content_hash values
tests/unit/test_triage_advisory.py two regression tests (below)

Implementation (HOW)

The contract is the canonical owner (the workflow header says so); every other surface is a mirror. Package sources under packages/autopilot/ were edited, .agents/skills/ copies were regenerated with apm install, and the lockfile was then restored and patched surgically with compute_file_hash / compute_local_package_hash -- the same functions the snapshot tests use -- because a full apm install with the local CLI rewrote 1500 unrelated lockfile lines (apm_version, licenses).

The diagram shows how the contract fans out to each consumer; dashed nodes are the sources this PR edits.

flowchart LR
    C["label-contract.json<br/>canonical owner"]:::new
    C -->|"allowlist + aliases"| P["triage_state.py<br/>pillar dimension"]:::new
    C -->|"literal mirror"| W["triage-panel.md<br/>add-labels allowlist"]:::new
    W -->|"gh aw compile v0.89.15"| L["triage-panel.lock.yml"]
    C -->|"apm install"| A[".agents/skills copies<br/>+ apm.lock.yaml hashes"]
    P --> G{"labels on issue"}
    L --> G
    classDef new stroke-dasharray: 5 5
Loading

Trade-offs

  • Kept the payload key classification.theme. Renaming it to pillar would change the schema_version 2 recommendation contract and the dashboard's compiled client (dist/). The worker SKILL now states the key carries the pillar/* value. A key rename can follow as its own bounded change.
  • Allowlisted all five pillars, not only the mapped two. Triage should be able to propose any roadmap pillar; the planner still allows only one per issue and only if the label exists in the repo.
  • Curator pillars win over the mechanical mapping. 52 of 53 issues already had a curator-chosen pillar; keeping it avoids two pillars on one issue (coordinator decision).
  • Guard built by concatenation. The test builds "theme" + "/" so the repo-wide grep it enforces stays empty, including the test itself.

Benefits

  1. git grep -F 'theme/' returns nothing (exit 1) on this branch.
  2. Two conflicting pillar proposals fail closed (Conflicting proposed pillar) instead of applying both.
  3. An existing security label now occupies the pillar dimension, so triage does not add a second pillar on top of it.
  4. Workflow allowlist and contract stay in lockstep (existing parity test passes on the recompiled lock).

Label backfill (done 2026-11-12)

Rule (coordinator decision by Daniel Meppiel (@danielmeppiel), relayed by Lane G): an issue that already carries a pillar/* keeps it and only drops its theme/*; an issue without a pillar gets the mapped one (portability -> consume, governance/security -> govern). Never two pillars.

Result Count
Open issues that carried theme/* 53
Kept their curator-chosen pillar, theme/* removed 52
Received a mapped pillar (#2990 -> pillar/consume) 1
Open issues still carrying theme/* 0
Open issues with more than one pillar/* (whole repo) 0

Note

Post-merge (Lane L / coordinator): delete the theme/portability, theme/governance and theme/security label definitions only after this PR merges. 6 open PRs (#2030, #2602, #2637, #2933, #3105, #3367) still carry theme/* and no pillar; deleting the definitions removes those labels. PRs were left untouched.

Issue and approved scope

Issue: Fixes #3634

Human scope-approval comment: #3634 (comment) (eligibility.cjs from trusted origin/main 90e76bf: record-present, approver and review contact Daniel Meppiel (@danielmeppiel); fresh confirmation relayed by the Lane G delivery session on 2026-11-12).

Does this PR complete the issue, or what remains? It completes the issue except deleting the three theme/* label definitions, which happens after merge (see the post-merge note).

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Maintenance / refactor

Testing

  • Tested locally
  • All existing tests pass (targeted files below; CI runs the full suite)
  • Added tests for new functionality (if applicable)

Scenario evidence

Scenario Test Principle
Triage proposes at most one pillar; an existing pillar or security alias blocks another tests/unit/test_triage_advisory.py::test_pillar_is_a_single_valued_classification_dimension Governance by default
No tracked file references the retired family; contract allowlists exactly five pillars tests/unit/test_triage_advisory.py::test_automation_classifies_with_pillar_labels_only Governance by default
Workflow allowlist equals contract; lock hashes match source tests/unit/test_triage_panel_lock.py (existing) Reproducibility
Installed skills and lockfile hashes match package sources tests/unit/test_triage_advisory.py::test_local_package_snapshots_match_lockfile (existing) Reproducibility

Mutation-break: reverting the planner to ("type", "theme") fails the first test; appending a theme/security line to packages/autopilot/README.md fails the second. Both pass after restore.

Validation output
$ .venv/bin/python -m pytest tests/unit/test_triage_advisory.py tests/unit/test_triage_panel_lock.py tests/unit/test_triage_fetch_queue.py -q
78 passed   (after staging; the snapshot test reads the git index)

$ node --test packages/apm-contributor-dashboard/tests/logic.test.mjs packages/apm-contributor-dashboard/tests/server.test.mjs
tests 167, pass 167, fail 0

$ node --test packages/autopilot/autopilot-maintainer-canvas/tests/*.test.mjs
tests 45, pass 45, fail 0

$ ruff check / ruff format --check (CI path list), pylint R0801, scripts/lint-auth-signals.sh
All checks passed! / 2154 files already formatted / 10.00/10 / [+] auth-signal lint clean

$ git grep -n -I -F 'theme/'; echo $?
1

How to test

  • git grep -n -F 'theme/' returns nothing.
  • uv run --extra dev pytest tests/unit/test_triage_advisory.py tests/unit/test_triage_panel_lock.py -q
  • grep -c pillar/ .github/workflows/triage-panel.lock.yml shows the allowlist entries.
  • After merge, dispatch Triage Panel on one issue and confirm it proposes a pillar/* label.

Spec conformance (OpenAPM v0.1)

  • Spec edit: docs/src/content/docs/specs/openapm-v0.1.md updated
    (new/changed <a id="req-XXX"></a> anchor + prose + Appendix C
    row).
  • Manifest edit: docs/src/content/docs/specs/manifests/openapm-v0.1.requirements.yml
    updated.
  • Test edit: a @pytest.mark.req("req-XXX") test under
    tests/spec_conformance/ added or extended.
  • CONFORMANCE.{md,json} regenerated via
    uv run --extra dev python -m tests.spec_conformance.gen_statement
    and committed.
  • N/A -- this PR does not change OpenAPM-observable behaviour.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Triage now classifies with the roadmap pillar/* labels (consume, produce,
govern, ecosystem, foundations). Mapping for legacy content:
portability -> consume, governance -> govern, security -> govern.

- label-contract.json (all 8 copies): pillar/* allowlist; the legacy
  `security` read alias maps to pillar/govern.
- triage_state.py: pillar is the single-valued classification dimension.
- triage-panel.md add-labels allowlist; lock recompiled with gh-aw v0.89.15.
- Triage worker prose/templates, autopilot README, maintainer canvas
  label chips, and the contributor-dashboard fixture.
- apm.lock.yaml: only the changed deployed-file and package hashes.
- Regression tests: pillar conflicts fail closed; no tracked file names
  the retired label family.

Refs #3634

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 12, 2026 15:30
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ðŸŸĒ Approval recommended

The review reports no active issues with the pillar-based triage migration.

No open issues 🎉

What changed in this PR

Updates APM’s issue and PR triage automation to use roadmap pillar/* labels, implementing the code portion of #3634. Live-label backfill and deletion remain a separate maintainer decision.

Changes:

  • Replaces legacy classification allowlists with five pillars and updates planners to reject conflicting pillar proposals.
  • Synchronizes workflow output permissions, worker guidance, installed copies, lock hashes, and canvas badges while preserving the classification.theme payload key.
  • Adds migration regression tests, updates the dashboard fixture, and records the change in the changelog.
File Description
tests/​unit/​test_triage_advisory.py Adds pillar-conflict, alias, allowlist, and retired-reference checks.
packages/​autopilot/​README.md Documents pillar-based classification.
packages/​autopilot/​autopilot-pr-triage-worker/​.apm/​skills/​autopilot-pr-triage-worker/​assets/​pr-triage-template.md Updates PR advice terminology to pillars.
packages/​autopilot/​autopilot-pr-triage-worker/​.apm/​skills/​autopilot-pr-triage-worker/​assets/​label-contract.json Updates PR worker labels and the security alias.
packages/​autopilot/​autopilot-pr-triage-scheduler/​.apm/​skills/​autopilot-pr-triage-scheduler/​scripts/​triage_state.py Rejects conflicting PR pillar additions.
packages/​autopilot/​autopilot-pr-triage-scheduler/​.apm/​skills/​autopilot-pr-triage-scheduler/​assets/​label-contract.json Updates PR scheduler labels and the security alias.
packages/​autopilot/​autopilot-maintainer-canvas/​.apm/​extensions/​autopilot-maintainer/​ui.mjs Displays pillar badges instead of theme badges.
packages/​autopilot/​autopilot-issue-triage-worker/​SKILL.md Defines pillar guidance and preserves payload compatibility.
packages/​autopilot/​autopilot-issue-triage-worker/​assets/​triage-template.md Updates issue advice terminology to pillars.
packages/​autopilot/​autopilot-issue-triage-worker/​assets/​label-contract.json Updates issue worker labels and the security alias.
packages/​autopilot/​autopilot-issue-triage-scheduler/​.apm/​skills/​autopilot-issue-triage-scheduler/​scripts/​triage_state.py Rejects conflicting issue pillar additions.
packages/​autopilot/​autopilot-issue-triage-scheduler/​.apm/​skills/​autopilot-issue-triage-scheduler/​assets/​label-contract.json Updates issue scheduler labels and the security alias.
packages/​apm-contributor-dashboard/​tests/​server.test.mjs Uses a pillar value in the legacy payload fixture.
CHANGELOG.md Records the triage taxonomy migration.
apm.lock.yaml Refreshes affected package and deployed-file hashes.
.github/​workflows/​triage-panel.md Updates permitted output labels and occupied-dimension guidance.
.github/​workflows/​triage-panel.lock.yml Synchronizes compiled allowlists and workflow metadata.
.agents/​skills/​autopilot-pr-triage-worker/​assets/​pr-triage-template.md Synchronizes the installed PR advice template.
.agents/​skills/​autopilot-pr-triage-worker/​assets/​label-contract.json Synchronizes the installed PR worker contract.
.agents/​skills/​autopilot-pr-triage-scheduler/​scripts/​triage_state.py Synchronizes installed PR pillar-conflict enforcement.
.agents/​skills/​autopilot-pr-triage-scheduler/​assets/​label-contract.json Synchronizes the installed PR scheduler contract.
.agents/​skills/​autopilot-issue-triage-worker/​SKILL.md Synchronizes installed pillar and payload guidance.
.agents/​skills/​autopilot-issue-triage-worker/​assets/​triage-template.md Synchronizes the installed issue advice template.
.agents/​skills/​autopilot-issue-triage-worker/​assets/​label-contract.json Synchronizes the installed issue worker contract.
.agents/​skills/​autopilot-issue-triage-scheduler/​scripts/​triage_state.py Synchronizes installed issue pillar-conflict enforcement.
.agents/​skills/​autopilot-issue-triage-scheduler/​assets/​label-contract.json Synchronizes the installed issue scheduler contract.

Review effort: Balanced

Pillar is now a single-valued classification dimension: the planner
raises on a second proposed pillar and the workflow never adds a label
to an occupied dimension. "Primary" was carried over from the theme
wording and implied secondary pillars were allowed. Updates the package
source, the installed copy, and the two lockfile hashes it moves.

Addresses doc-writer panel follow-up on
packages/autopilot/autopilot-issue-triage-worker/SKILL.md:288.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@danielmeppiel

Copy link
Copy Markdown
Collaborator Author

APM Review Panel: ship_with_followups

Pillar-label migration is fold-complete: the in-scope doc wording fix landed in a1d2090, CI is green across all checks, and the two remaining items are post-merge housekeeping.

panel-mode=delta; personas=doc-writer,apm-ceo (prior pass this run: panel-mode=lean; personas=doc-writer,supply-chain-security-expert,apm-ceo; supply-chain added ad hoc because the gh-aw add-labels allowlist and apm.lock.yaml hashes changed)

cc Daniel Meppiel (@danielmeppiel) -- a fresh advisory pass is ready for your review.

The lean pass raised one in-scope finding and nothing else. Doc-writer flagged that the triage worker SKILL said "one primary pillar" although the planner now rejects any second pillar. Supply-chain found no issues: the safe-output allowlist moves from 3 theme/* to 5 pillar/* classification labels with single-valued enforcement, the recompiled lock file differs only in metadata hashes and the three allowlist blobs (no new triggers, permissions, secrets, or pull_request_target), and the patched lockfile hashes match the package sources. Commit a1d2090 folded the wording fix in the package source, the installed copy, and the two lockfile hashes it moves; the delta doc-writer pass confirms it and finds nothing new.

The scope record in #3634 is met in code: git grep -F 'theme/' finds nothing on the merged tree, the two new regression tests pass and were mutation-break verified, and every check passes at the exact head. The new grep guard encodes the approved done-when literally; a future PR with a legitimate theme/ path would trip it, but the failure is self-explaining and easy to narrow. Keeping the payload key classification.theme (now carrying the pillar/* value) avoids a schema_version bump and is called out in the PR body.

Aligned with: governed by policy -- the label contract stays the single source of truth and triage enforces one pillar per item; OSS community -- 53 open issues were backfilled and contributors see one label family.

Panel summary

Persona B R N Takeaway
Doc Writer 0 0 0 Fold a1d2090 resolves the "primary pillar" finding; "five-axis taxonomy" matches the canonical contract wording; no new issues.

B = blocking-severity findings, R = recommended, N = nits.
Counts are signal strength, not gates. The maintainer ships.

Top 2 follow-ups

  1. [APM CEO] Delete the theme/portability, theme/governance and theme/security label definitions after merge -- the last done-when item of Migrate automation from theme/* to pillar/* labels #3634; six open PRs still carry theme/* and deletion strips them, so it cannot happen before merge.
  2. [APM CEO] Rename payload key classification.theme to classification.pillar in a future bounded change -- it is a schema_version 2 contract surface read by the dashboard compiled client.

Recommendation

Fold-complete with zero open panel findings. Ship once the required human review is granted; delete the theme/* labels right after merge and open a bounded issue for the key rename when the next schema version is planned.

Folded in this run

  • (panel) doc-writer: "one primary pillar" -> "one pillar" in the triage worker SKILL (package source and installed copy) plus the two lockfile hashes it moves -- resolved in a1d2090.
  • (merge) origin/main 1a37071 merged into the branch with no conflicts -- resolved in b753ffd.

Copilot signals reviewed

  • Copilot review on 1a80e2d recommended approval with zero inline comments; a second fetch after the fold found no new comments. Nothing to classify.

Deferred (out-of-scope follow-ups)

  • (panel) Delete the three theme/* label definitions -- scope boundary: repository label administration that must follow the merge (6 open PRs still carry theme/*); a landing action, not a diff change.
  • (panel) Rename payload key classification.theme -> classification.pillar -- scope boundary: changes the schema_version 2 recommendation contract and the dashboard compiled client; not a label reference.

Regression-trap evidence (mutation-break gate)

  • tests/unit/test_triage_advisory.py::test_pillar_is_a_single_valued_classification_dimension -- reverted planner dimensions to ("type", "theme"); test FAILED as expected; guard restored.
  • tests/unit/test_triage_advisory.py::test_automation_classifies_with_pillar_labels_only -- appended a retired-family label line to packages/autopilot/README.md; test FAILED as expected; file restored.

Lint contract

ruff check and ruff format --check (CI path list, ruff 0.15.12), pylint R0801, scripts/lint-auth-signals.sh and scripts/lint-architecture-boundaries.sh all silent on the merged head. Targeted tests: tests/unit/test_triage_advisory.py, test_triage_panel_lock.py, test_triage_fetch_queue.py 78 passed; dashboard node tests 167/167; maintainer canvas node tests 45/45.

CI

All checks pass at a1d2090 (CI run 43261260257: Lint, Build & Test shards 1-2, Lifecycle Smoke shards 1-2, Windows Compatibility Gate, Windows Native Symlink Acceptance, Architecture Ratchets, PR Binary Smoke; CodeQL 43261260198; Merge Gate gate; NOTICE Drift; license/cla pass) (after 0 CI fix iterations).

Mergeability status

PR head SHA CEO stance iters folds defers Copilot rounds CI mergeable mergeStateStatus notes
#3636 a1d2090 ship_with_followups 1 1 2 2 green MERGEABLE BLOCKED awaiting required review

Convergence

1 outer iteration; 2 Copilot rounds. Final panel stance: ship_with_followups. Closes #3634 on merge; the post-merge label deletion above is the remaining done-when item. Ready for maintainer review.

Full per-persona findings

Doc Writer

No findings (delta). Lean pass finding, now folded: [recommended] SKILL.md said "one primary pillar" but the planner rejects any second pillar, at packages/autopilot/autopilot-issue-triage-worker/SKILL.md:288. Resolved in a1d2090.

Supply Chain Security Expert (lean pass)

No findings.

This panel is advisory. It does not block merge. Re-apply the
panel-review label after addressing feedback to re-run.


Generated by autopilot-pr-merge-worker. This comment is AI-generated and may contain errors.

@danielmeppiel
Daniel Meppiel (danielmeppiel) merged commit 8184b0d into main Nov 12, 2026
32 checks passed
@danielmeppiel
Daniel Meppiel (danielmeppiel) deleted the danielmeppiel-migrate-theme-to-pillar-labels branch November 12, 2026 18:05
Daniel Meppiel (danielmeppiel) added a commit that referenced this pull request Nov 12, 2026
Keep #3636's theme/* -> pillar/* migration and this PR's contract
repairs. apm.lock.yaml: main's lock with only the four touched
packages' records and the two check_required_agents.py deployments
refreshed; apm audit --ci passes with no drift.

Co-authored-by: sergio-sisternes-epam <sergio-sisternes-epam@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate automation from theme/* to pillar/* labels

2 participants