Retry to delete distribution VHD for up to 10 seconds - #41153
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the robustness of WSL distribution un-registration by retrying deletion of the distro VHD when the file is temporarily in use (e.g., due to sharing violations), reducing intermittent test failures during cleanup.
Changes:
- Replace single-attempt VHD deletion with a bounded retry loop (100ms interval, up to 10 seconds).
- Retry only on
ERROR_SHARING_VIOLATION, logging the failure after the timeout expires.
Ben Hillis (benhillis)
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change adds logic to retry deleting WSL distribution VHDs for up to 10 seconds. We've seen test failures caused by that file being in used during un-registration.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed