Skip to content

Document what the session creation parameters do, and which of them ae visible to all users on the machine - #41020

Merged
Blue (OneBlue) merged 2 commits into
masterfrom
user/oneblue/session-create-doc
Jul 7, 2026
Merged

Document what the session creation parameters do, and which of them ae visible to all users on the machine#41020
Blue (OneBlue) merged 2 commits into
masterfrom
user/oneblue/session-create-doc

Conversation

@OneBlue

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

This change adds explanations for what the session creation fields do, and which of them are visible to all users on the machine

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings July 7, 2026 20:04
@OneBlue
Blue (OneBlue) requested a review from a team as a code owner July 7, 2026 20:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WSLC SDK documentation to explain what the session creation parameters represent and to clarify which session metadata can be observed machine-wide.

Changes:

  • Documented the meaning of Name / name and StoragePath / storagePath across C#, C++, and C API references.
  • Documented that session names are machine-wide identifiers and that duplicate names fail with ERROR_ALREADY_EXISTS.
  • Documented which session metadata (name, creator SID, creator PID) is visible to other users on the same machine.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
doc/docs/api-reference/csharp/settings-classes/sessionsettings.md Adds parameter semantics and notes on machine-wide visibility for C# SessionSettings.
doc/docs/api-reference/cpp/settings-classes/sessionsettings.md Adds constructor parameter semantics and visibility notes for C++/WinRT SessionSettings.
doc/docs/api-reference/c/session-apis/wslcinitsessionsettings.md Expands the parameter table with comments and adds visibility/name uniqueness notes for the C API.

Comment thread doc/docs/api-reference/csharp/settings-classes/sessionsettings.md Outdated
Comment thread doc/docs/api-reference/cpp/settings-classes/sessionsettings.md Outdated
Comment thread doc/docs/api-reference/c/session-apis/wslcinitsessionsettings.md Outdated
Comment thread doc/docs/api-reference/c/session-apis/wslcinitsessionsettings.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 7, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

Comment thread doc/docs/api-reference/csharp/settings-classes/sessionsettings.md
Comment thread doc/docs/api-reference/csharp/settings-classes/sessionsettings.md
Comment thread doc/docs/api-reference/cpp/settings-classes/sessionsettings.md
Comment thread doc/docs/api-reference/cpp/settings-classes/sessionsettings.md
Comment thread doc/docs/api-reference/c/session-apis/wslcinitsessionsettings.md
Comment thread doc/docs/api-reference/c/session-apis/wslcinitsessionsettings.md
@OneBlue
Blue (OneBlue) merged commit 82ae2cd into master Jul 7, 2026
14 checks passed
@OneBlue
Blue (OneBlue) deleted the user/oneblue/session-create-doc branch July 7, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants