Repository navigation
CmdPal: Fix context menu Ctrl+Enter in submenus and initial highlight - #51290
Merged
Michael Jolley (michaeljolley) merged 2 commits intoOct 14, 2026
Merged
Michael Jolley (michaeljolley) merged 2 commits into
Michael Jolley (michaeljolley) merged 2 commits into
Conversation
- Hides the selection highlight on open until the user navigates or filters. - Keeps Ctrl+Enter for the item's secondary command, not a submenu's first command. - Releases the hidden selection when the menu closes. - Adds a new sample for submenu without requested shortcuts.
JiÅÃ PolÃĄÅĄek (jiripolasek)
added
the
Product-Command Palette
JiÅÃ PolÃĄÅĄek (jiripolasek)
requested a review
from Michael Jolley (michaeljolley)
October 14, 2026 05:10
github-actions
Bot
added
the
Needs-Author-Feedback
â PR intakeAll automated intake checks now pass. Thanks for the updates! Automated PR intake; PowerToys maintainers make final decisions. |
github-actions
Bot
added
Ready for review
and removed
Needs-Author-Feedback
Michael Jolley (michaeljolley)
deleted the
dev/jpolasek/b/50926-cmdpal-context-menu-polish
branch
October 14, 2026 21:55
Collaborator
Author
|
Boliang Zhang (LegendaryBlair)
pushed a commit
that referenced
this pull request
Oct 15, 2026
âĶ#51290) <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR improve behavior of update context menu: - Hides the selection highlight on open until the user navigates or filters. - Keeps Ctrl+Enter for the item's secondary command, not a submenu's first command. - Releases the hidden selection when the menu closes. - Adds a new sample for submenu without requested shortcuts. ## Toaster wants a picture? Here's one! <img width="600" height="480" alt="bravelittletoasteranimationGIFbyCoolidgeCornerTheatre" src="https://github.com/user-attachments/assets/4fa8527f-106b-4cde-802a-aa7d5a9692b8" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #50926 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed (cherry picked from commit f24abcf) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR improve behavior of update context menu:
Toaster wants a picture? Here's one!
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed