Repository navigation
CmdPal: Fixes missing app icons after list recycling - #50988
Merged
Michael Jolley (michaeljolley) merged 2 commits intoOct 5, 2026
Merged
Michael Jolley (michaeljolley) merged 2 commits into
Michael Jolley (michaeljolley) merged 2 commits into
Conversation
- IconBox defers unload cleanup and preserves requests for rows that remain loaded. - The unload controller coalesces callbacks and reads IsLoaded directly. - Request invalidation advances the version before releasing demand and preserves pending refreshes. - XamlRoot subscription handling ignores stale root events and contains teardown failures.
JiÅÃ PolÃĄÅĄek (jiripolasek)
added
Product-Command Palette
Michael Jolley (michaeljolley)
enabled auto-merge (squash)
October 5, 2026 19:53
Michael Jolley (michaeljolley)
approved these changes
Oct 5, 2026
Michael Jolley (michaeljolley)
deleted the
dev/jpolasek/b/50984-cmdpal-iconbox-unload-race
branch
October 5, 2026 19:54
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR fixes blank or fallback icons in All apps when a stale
Unloadedevent invalidates a freshly loaded row's icon request. Cleanup now waits for the settledIsLoadedstate, preserving requests for visible rows.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed