Repository navigation
CmdPal: Fix object initialization in Shelf tests - #50921
Merged
Michael Jolley (michaeljolley) merged 1 commit intoSep 30, 2026
Merged
Michael Jolley (michaeljolley) merged 1 commit into
Michael Jolley (michaeljolley) merged 1 commit into
Conversation
JiÅÃ PolÃĄÅĄek (jiripolasek)
added
the
Product-Command Palette
JiÅÃ PolÃĄÅĄek (jiripolasek)
marked this pull request as ready for review
September 30, 2026 21:39
ð§ PR intakeVisual evidence: Not needed â The changed files do not indicate a visible UI change. No visual evidence is expected. Recommendation
â Ready for reviewThis PR passed the automated intake checks and is ready for maintainer review. Automated PR intake; PowerToys maintainers make final decisions. |
Michael Jolley (michaeljolley)
approved these changes
Sep 30, 2026
Michael Jolley (michaeljolley)
enabled auto-merge (squash)
September 30, 2026 22:08
Michael Jolley (michaeljolley)
deleted the
dev/jpolasek/b/cmdpal-fix-shelf-test-object-initialization
branch
September 30, 2026 22:36
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Initialize _itemSnapshot in the shelf unit test to match normal construction. The fixture bypasses constructors and field initializers, leaving the snapshot null and causing four test failures with the cleanup added in #50833.
This will be properly fixed with upcoming refactor.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed