[Langning Chen (langningchen)]

Summary of the Pull Request

This PR fixes the coordinate misalignment and cropping inaccuracies in the Crop and Lock utility by aligning the coordinate calculation system with GDI boundaries.

The root cause was a mismatch between GDI and DWM coordinate spaces. PrintWindow draws the target window using standard GDI boundaries (which include invisible resize borders and drop shadows). However, the code was calculating windowRect using DwmGetWindowAttribute with DWMWA_EXTENDED_FRAME_BOUNDS (DWM visible boundaries). This discrepancy caused the calculated offsetX and offsetY offsets to be too small, resulting in the cropped image being shifted (capturing empty margins/shadows on one side and clipping the actual content on the other).

By switching to ::GetWindowRect, all coordinate and offset math is unified into the GDI coordinate space, ensuring pixel-perfect cropping alignment.

PR Checklist

• Closes: Crop And Lock isn’t accurate enough.窗口裁剪器不精准 #49627

• Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end-user-facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

• Modified both ScreenshotCropAndLockWindow.cpp and ThumbnailCropAndLockWindow.cpp to use ::GetWindowRect instead of DwmGetWindowAttribute when querying target window bounds.
• Updated comments in ThumbnailCropAndLockWindow.cpp to reflect that bounds are now reported by GetWindowRect.
• Resolves the clipping issues particularly noticeable under high DPI scaling environments (e.g., 125%, 150%).

Validation Steps Performed

• Manual verification: Built and ran the project on a scaled high-DPI monitor.
• Verified that Crop and Lock now accurately crops the targeted window precisely matching the red selection overlay box.
• Attached a comparison GIF below (left: Before, right: After).
  (Note: The thin black borders remaining on the left and right sides in the modified version (right) are not a cropping alignment artifact; they are the actual internal borders/padding belonging to the targeted application window itself).

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[Langning Chen (langningchen)]

@microsoft-github-policy-service agree

[Copilot]

Pull request overview

This PR updates Crop and Lock’s window-bound calculations to use GetWindowRect (GDI-style window bounds) instead of DwmGetWindowAttribute(DWMWA_EXTENDED_FRAME_BOUNDS), aligning the coordinate space used for cropping math with what PrintWindow/GDI capture produces and addressing misalignment under DPI scaling.

Changes:

• Switched window bounds retrieval to GetWindowRect in the screenshot capture path.
• Switched window bounds retrieval to GetWindowRect in the DWM thumbnail crop path and updated the related inline comment.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/modules/CropAndLock/CropAndLock/ThumbnailCropAndLockWindow.cpp	Uses GetWindowRect for target window bounds when translating the overlay’s client-relative crop rect into window-space for DWM thumbnail source rects.
src/modules/CropAndLock/CropAndLock/ScreenshotCropAndLockWindow.cpp	Uses GetWindowRect for target window bounds to compute correct client-to-window offsets before cropping the PrintWindow bitmap.

[欣晓末 (XinXiaoMoDear)]

要是能快点写入正式版就好了😭

[Muyuan Li (MuyuanMS)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).