Repository navigation
CmdPal: Set IsLoading in Window Walker during search - #47919
Merged
Michael Jolley (michaeljolley) merged 2 commits intoMay 18, 2026
Merged
Conversation
Set IsLoading=true before querying open windows in WindowWalkerListPage.GetItems() and reset it in a finally block so the UI shows a loading indicator while results are being fetched. Closes #38314 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Jolley (michaeljolley)
added
the
Product-Command Palette
Michael Jolley (michaeljolley)
marked this pull request as ready for review
May 15, 2026 15:36
Contributor
There was a problem hiding this comment.
Pull request overview
Adds loading-state handling to the Command Palette Window Walker page so users get visual feedback while open-window results are queried.
Changes:
- Converts
GetItems()from expression-bodied to block-bodied. - Sets
IsLoading = truebefore querying and resets it in afinallyblock.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Michael Jolley (michaeljolley)
enabled auto-merge (squash)
May 16, 2026 01:33
Mike Griese (zadjii-msft)
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Sets
IsLoading = truebefore querying open windows inWindowWalkerListPage.GetItems()and resets it in afinallyblock, so the UI shows a loading indicator while Window Walker results are being fetched.Closes #38314
PR Checklist
IsLoading=true #38314Detailed Description
The Window Walker extension was not setting
IsLoadingduring its search operation. This meant users got no visual feedback that a search was in progress. This follows the same pattern used by other extensions (AllAppsPage, IndexerPage, etc.).Validation Steps Performed