Skip to content

Allow specifying the meterNameConsumer for HighCardinalityTagsDetector - #4028

Merged
jonatan-ivanov merged 2 commits into
micrometer-metrics:mainfrom
sean-heller:sh_AllowOverridingHCTD
Oct 9, 2024
Merged

jonatan-ivanov merged 2 commits into
micrometer-metrics:mainfrom
sean-heller:sh_AllowOverridingHCTD

Conversation

@sean-heller

Copy link
Copy Markdown
Contributor

Currently, it's not possible to specify the meterNameConsumer, so folks are just left with the default functionality of logging a warning then logging debug messages.

This change would allow for users to specify their own consumer - one use case for this would be to add a new metric that is marked every time there is a metric with high cardinality detected, which could be used for alerting (vs. just looking through logs).

Let me know what you think! Thanks!

@pivotal-cla

Copy link
Copy Markdown

@sean-heller Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla

Copy link
Copy Markdown

@sean-heller Thank you for signing the Contributor License Agreement!

@sean-heller
sean-heller force-pushed the sh_AllowOverridingHCTD branch from 993b246 to e2e9029 Compare August 11, 2023 15:08
@jonatan-ivanov
jonatan-ivanov force-pushed the sh_AllowOverridingHCTD branch from e2e9029 to f437ef1 Compare October 8, 2024 21:36
@jonatan-ivanov

Copy link
Copy Markdown
Member

@sean-heller Thank you for the PR and sorry to not getting back to you earlier!
I rebased your changes on top of main and modified them a little so that users can specify the way the HighCardinalityTagsDetector is created. This way they can specify any arbitrary parameters used right now and those as well that will possibly be added in the future.
What do you think?

@jonatan-ivanov jonatan-ivanov added enhancement A general enhancement module: micrometer-core An issue that is related to our core module labels Oct 8, 2024
@jonatan-ivanov jonatan-ivanov added this to the 1.14.0-RC1 milestone Oct 8, 2024
@jonatan-ivanov
jonatan-ivanov merged commit 6f40094 into micrometer-metrics:main Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A general enhancement module: micrometer-core An issue that is related to our core module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants