Repository navigation
fix(ci): unblock package check, dependabot label, and ty tracking - #656
Merged
martin-majlis merged 2 commits intoSep 3, 2026
Merged
Conversation
martin-majlis
force-pushed
the
fix/twine-metadata-2.5-and-dependabot-label
branch
from
September 3, 2026 20:05
abf5921 to
1a0ebb8
Compare
Three pre-existing issues, none caused by a single dependency bump:
- Build package: hatchling now emits Metadata-Version 2.5, but twine
6.2.0 monkeypatches the allowed metadata versions to cap at 2.4 and
rejects the wheel ("'2.5' is not a valid metadata version"). Pin twine
to 7.0.0 (supports 2.5) and relock. Pinned with == (not >=) to match
the sibling build tools (setuptools, wheel) so Dependabot keeps it
current; Dependabot had not proposed the 6->7 major bump on its own.
- Dependabot Pull Request: the major-update branch adds the
"requires-manual-qa" label, but the label does not exist in the repo,
so `gh pr edit --add-label` exits 1 and fails the check. Create the
label idempotently with `gh label create --force` before adding it.
- ty was declared twice in the dev group (ty==0.0.27 and ty>=0.0.27).
Dependabot cannot reconcile a package declared twice with conflicting
specifiers, so it silently skipped ty entirely -- it never opened a
single ty PR and ty drifted 51 releases behind (0.0.27 vs 0.0.78).
Remove the redundant >= line so Dependabot can track it going forward.
No version change here.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BifaamrWqi1EhVUhTkVBPC
martin-majlis
force-pushed
the
fix/twine-metadata-2.5-and-dependabot-label
branch
from
September 3, 2026 20:11
1a0ebb8 to
82a1d99
Compare
Replace the remaining open lower bounds (ruff, pytest-recording, vcrpy) with exact pins at their currently-locked versions. Every dependency is now == pinned so Dependabot proposes each upgrade as a reviewable PR, avoiding the silent drift that left twine and ty stuck. requires-python and the python_version environment marker are intentionally left as >=. No version changes -- pins match the existing lock. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BifaamrWqi1EhVUhTkVBPC
martin-majlis
deleted the
fix/twine-metadata-2.5-and-dependabot-label
branch
September 3, 2026 20:20
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 76 76
Lines 3373 3373
=======================================
Hits 3172 3172
Misses 201 201 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pre-existing repo issues that surface on every open PR (including dependabot #638), and hardens dependency management so nothing silently drifts again. None are caused by a dependency bump itself.
1.
Build packagecheck (make check-package)hatchlingnow emitsMetadata-Version: 2.5, but twine 6.2.0 monkeypatchespackaging's allowed metadata versions to cap at2.4, sotwine checkrejects the wheel:Fix: pin
twine==7.0.0(supports metadata 2.5) and relock. Verified locally —twine checknowPASSEDfor both wheel and sdist.2.
Dependabot Pull RequestcheckOn a major update of a "production" dependency (any GitHub Action bump qualifies), the workflow runs
gh pr edit --add-label "requires-manual-qa", but that label does not exist in the repo:Fix: create the label idempotently with
gh label create --forcebefore adding it.3.
tywas invisible to Dependabot (duplicate declaration)tywas declared twice in thedevgroup —ty==0.0.27andty>=0.0.27. Dependabot cannot reconcile a package declared twice with conflicting specifiers, so it silently skippedtyentirely: it never opened a single ty PR, and ty drifted 51 releases behind (0.0.27 vs 0.0.78). Removed the redundant>=line so Dependabot can track it. No version change.4. Pin every package with
==(was>=for a few)Replaced the remaining open lower bounds (
ruff,pytest-recording,vcrpy) with exact pins at their currently-locked versions. All dependencies are now==pinned, so Dependabot proposes each upgrade as a reviewable PR instead of leaving>=ranges to drift silently (the failure mode that stranded twine at a stale major and hidty).requires-pythonand thepython_versionenvironment marker are intentionally left as>=. No version changes — pins match the existing lock.Not addressed here (out of scope / not code bugs)
summary_zh_cn/zh_tw, small mismatches). Fails onmastertoo; expected, needs snapshot re-record.Testing
uv build && uv run twine check dist/*→ both artifactsPASSEDuv lock→ only specifier changes, no version changespre-commiton changed files → all hooks pass🤖 Generated with Claude Code