Repository navigation
Use solve_kkt! instead of solve_kkt_system! - #577
Merged
Merged
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/IPM/factorization.jl b/src/IPM/factorization.jl
index e8576aeb..c7124780 100644
--- a/src/IPM/factorization.jl
+++ b/src/IPM/factorization.jl
@@ -131,7 +131,7 @@ function solve_kkt!(
end
-function solve_kkt!(kkt::SparseCondensedKKTSystem{T}, w::AbstractKKTVector) where T
+function solve_kkt!(kkt::SparseCondensedKKTSystem{T}, w::AbstractKKTVector) where {T}
(n,m) = size(kkt.jt_csc)
|
Codecov Reportâ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 84.19% 84.19%
=======================================
Files 52 52
Lines 4675 4675
=======================================
Hits 3936 3936
Misses 739 739 â View full report in Codecov by Sentry. ð New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will be consistent with
build_kkt!andfactorize_kkt!.I should check with François but I think that we forgot to rename some
solve!in the documentation.I updated the documentation.