Repository navigation
[MOI] Reuse existing data structures from MOI on re-solve - #550
Conversation
a76b59a to
7944ff4
Compare
Codecov Reportâ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #550 +/- ##
==========================================
+ Coverage 75.17% 84.97% +9.79%
==========================================
Files 50 50
Lines 4617 4620 +3
==========================================
+ Hits 3471 3926 +455
+ Misses 1146 694 -452 â View full report in Codecov by Sentry. ð New features to boost your workflow:
|
2fc3614 to
b7a3295
Compare
d775b3f to
3719e35
Compare
8ea9c87 to
3d28c54
Compare
3719e35 to
a2bfe1c
Compare
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/ext/MadNLPMOI/MOI_wrapper.jl b/ext/MadNLPMOI/MOI_wrapper.jl
index b1b7b86e..cb6af0b3 100644
--- a/ext/MadNLPMOI/MOI_wrapper.jl
+++ b/ext/MadNLPMOI/MOI_wrapper.jl
@@ -1435,7 +1435,7 @@ function _setup_model(model::Optimizer)
model.jrows = jrows
model.jcols = jcols
- hessian_sparsity = has_hessian ? MOI.hessian_lagrangian_structure(model) : Tuple{Int,Int}[]
+ hessian_sparsity = has_hessian ? MOI.hessian_lagrangian_structure(model) : Tuple{Int, Int}[]
nnzh = length(hessian_sparsity)
hrows = Vector{Int}(undef, nnzh)
hcols = Vector{Int}(undef, nnzh) |
|
@franckgaga |
a2bfe1c to
03465b1
Compare
|
Niccee, many thanks ð Is the VectorNonlinearOracle also ready for MadNLP? |
|
Yes, we did it in #508. |
|
Yess, thank you both, will give it a spin for NMPC, I had some trouble with the built-in L-BFGS solver in the past. |
|
I worked a few hours recently on LBFGS and improved the implementation (see #537), I suggest to try it again when the release 0.9 will be available. @frapac With this PR, I don't recreate the internal "MOI model" (with the expression tree, buffers for AD, coloring structures, etc...) if not needed but I never reuse the workspace of MadNLP. |
f99986b to
81f3857
Compare
fe162a8 to
23a0911
Compare
23a0911 to
b887212
Compare
Similar to cvanaret/Uno#474, jump-dev/Ipopt.jl#516, jump-dev/KNITRO.jl#378