Repository navigation
Fixes docker check in isaaclab.sh script in systems where docker is not installed - #4180
Merged
Merged
Conversation
klakhi
requested review from
Mayankm96,
hhansen-bdai and
kellyguo11
as code owners
December 10, 2025 16:16
Contributor
Greptile OverviewGreptile SummaryImproved the
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Script as isaaclab.sh
participant FS as Filesystem
participant Proc as /proc
participant Comm as /proc/1/comm
Script->>Script: is_docker() called
Script->>FS: Check /.dockerenv exists
alt /.dockerenv exists
FS-->>Script: File found (Docker)
Script-->>Script: Return true
else /.dockerenv not found
Script->>FS: Check /run/.containerenv exists
alt /run/.containerenv exists
FS-->>Script: File found (Podman)
Script-->>Script: Return true
else /run/.containerenv not found
Script->>Proc: grep -qaE '(docker|containerd|kubepods|podman)' /proc/1/cgroup
alt Pattern matches
Proc-->>Script: Match found (Container)
Script-->>Script: Return true
else Pattern not found
Script->>Comm: cat /proc/1/comm
Comm-->>Script: Read process name
alt Process is containerd-shim
Script-->>Script: Return true
else Not containerd-shim
Script-->>Script: Return false (Not in container)
end
end
end
end
Script->>Script: Use result to skip VSCode setup if in container
|
Closed
2 of 4 tasks
Contributor
|
@nv-apoddubny could you help give this change a review? |
nv-apoddubny
approved these changes
Dec 11, 2025
nv-apoddubny
left a comment
Collaborator
There was a problem hiding this comment.
Removes /proc/mounts check. This could miss some edge cases where Docker volumes are mounted but cgroups don't show container info. The rest is looking good.
kellyguo11
pushed a commit
that referenced
this pull request
Dec 11, 2025
…ot installed (#4180) # Description the is_docker() check can sometimes detect that we are installing in docker even though docker is not available on the system, causing to downstream issues in the script. this fix narrows the checks for docker to avoid false positives. Fixes #4181 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
T-K-233
pushed a commit
to ucb-bar/IsaacLab
that referenced
this pull request
Dec 29, 2025
…ot installed (isaac-sim#4180) # Description the is_docker() check can sometimes detect that we are installing in docker even though docker is not available on the system, causing to downstream issues in the script. this fix narrows the checks for docker to avoid false positives. Fixes isaac-sim#4181 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Edify0991
pushed a commit
to Edify0991/IsaacLab
that referenced
this pull request
Jan 14, 2026
…ot installed (isaac-sim#4180) # Description the is_docker() check can sometimes detect that we are installing in docker even though docker is not available on the system, causing to downstream issues in the script. this fix narrows the checks for docker to avoid false positives. Fixes isaac-sim#4181 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
nitesh-subedi
pushed a commit
to nitesh-subedi/IsaacLab
that referenced
this pull request
Feb 5, 2026
…ot installed (isaac-sim#4180) # Description the is_docker() check can sometimes detect that we are installing in docker even though docker is not available on the system, causing to downstream issues in the script. this fix narrows the checks for docker to avoid false positives. Fixes isaac-sim#4181 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
csj-275
pushed a commit
to csj-275/IsaacLab
that referenced
this pull request
Jul 8, 2026
…ot installed (isaac-sim#4180) # Description the is_docker() check can sometimes detect that we are installing in docker even though docker is not available on the system, causing to downstream issues in the script. this fix narrows the checks for docker to avoid false positives. Fixes isaac-sim#4181 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the is_docker() check can sometimes detect that we are installing in docker even though docker is not available on the system, causing to downstream issues in the script. this fix narrows the checks for docker to avoid false positives.
Fixes #4181
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there