Repository navigation
Pins python version of pre-commmit.yaml workflow - #3929
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
Fixes failing pre-commit CI runs by pinning Python version to 3.12 in the GitHub Actions workflow.
- Added
python-version: "3.12"parameter toactions/setup-python@v3step - Addresses incompatibility between flake8 7.0.0 (specified in
.pre-commit-config.yaml) and Python 3.14 - Previously,
setup-python@v3defaulted to latest Python version (3.14), which caused pre-commit failures - Python 3.12 is compatible with all pre-commit hooks and aligns with the project's Python version usage in other workflows
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- The change is minimal, well-scoped, and directly addresses a documented CI failure. Pinning Python to 3.12 is a safe choice that aligns with other workflows in the repository (license-check uses 3.11, docs uses 3.11) and ensures compatibility with flake8 7.0.0.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/pre-commit.yaml | 5/5 | Pinned Python to 3.12 to fix flake8 7.0.0 incompatibility with Python 3.14 |
Sequence Diagram
sequenceDiagram
participant PR as Pull Request
participant GHA as GitHub Actions
participant Setup as setup-python@v3
participant PreCommit as pre-commit/action
participant Flake8 as flake8 7.0.0
PR->>GHA: Trigger workflow (opened/sync/reopen)
GHA->>Setup: Install Python
Note over Setup: Without version: installs latest (3.14)
Note over Setup: With version "3.12": installs 3.12
Setup->>GHA: Python environment ready
GHA->>PreCommit: Run pre-commit hooks
PreCommit->>Flake8: Execute flake8 linting
alt Python 3.14 (before fix)
Flake8->>PreCommit: ❌ Incompatibility error
PreCommit->>GHA: Workflow fails
else Python 3.12 (after fix)
Flake8->>PreCommit: ✓ Linting complete
PreCommit->>GHA: Workflow succeeds
end
1 file reviewed, no comments
Contributor
Test Results Summary2 669 tests 2 207 ✅ 2h 27m 26s ⏱️ For more details on these failures, see this check. Results for commit 6506a89. |
kellyguo11
approved these changes
Nov 3, 2025
Mayankm96
reviewed
Nov 4, 2025
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v3 | ||
| with: | ||
| python-version: "3.12" |
Contributor
There was a problem hiding this comment.
Does Isaac Sim 5.1 use Python 3.12 or 3.11? Might make sense to keep the version similar to that?
There was a problem hiding this comment.
Yeah, IsaacSim 5 requires Python 3.11, other versions don't work:
https://docs.isaacsim.omniverse.nvidia.com/latest/installation/install_python.html
From my point-of-view, this needs to be fixed. Tagging @hhansen-bdai for heads-up
kellyguo11
pushed a commit
that referenced
this pull request
Nov 26, 2025
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
kellyguo11
pushed a commit
that referenced
this pull request
Nov 26, 2025
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
koghalai123
pushed a commit
to koghalai123/IsaacLab
that referenced
this pull request
Dec 7, 2025
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
Edify0991
pushed a commit
to Edify0991/IsaacLab
that referenced
this pull request
Jan 14, 2026
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
csj-275
pushed a commit
to csj-275/IsaacLab
that referenced
this pull request
Jul 8, 2026
# Description pre-commit CI runs have been failing (see [example](https://github.com/isaac-sim/IsaacLab/actions/runs/19017065661/job/54306430424)) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pre-commit CI runs have been failing (see example) due to an incompatibility between our specified flake version and python 3.14, as python3.14 has started to be installed by the setup-python GHA. This PR pins python to 3.12 in order to fix these failures.
Type of change