Skip to content

Adds improved readout from install_deps.py - #3104

Merged
ooctipus merged 11 commits into
mainfrom
hhansen/improve_install_deps_readout
Aug 8, 2025
Merged

ooctipus merged 11 commits into
mainfrom
hhansen/improve_install_deps_readout

Conversation

@hhansen-bdai

@hhansen-bdai hhansen-bdai commented Aug 6, 2025 •

Copy link
Copy Markdown
Contributor

Description

This adds improved readout from the subprocesses in install_deps.py. It will now print the output instead of printing everything at once when the process is finished. It also has improved error handling. This will help users to have a better understanding of their build process and more easily resolve issues.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@hhansen-bdai
hhansen-bdai requested a review from Copilot August 6, 2025 16:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the user experience of the dependency installation process by implementing real-time output streaming and enhanced error handling in the install_deps.py script. The changes replace the previous approach of buffering all subprocess output until completion with a live streaming approach that provides immediate feedback to users.

  • Replaces subprocess.run with subprocess.Popen for real-time output streaming
  • Adds better error handling with descriptive error messages
  • Enhances user feedback during the installation process

Comment thread tools/install_deps.py Resolved
Comment thread tools/install_deps.py Resolved
Comment thread tools/install_deps.py Resolved
@hhansen-bdai hhansen-bdai self-assigned this Aug 6, 2025
hhansen-bdai and others added 10 commits August 7, 2025 11:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Hunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Hunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
@hhansen-bdai
hhansen-bdai force-pushed the hhansen/improve_install_deps_readout branch from 3b3e749 to 1d0c6cd Compare August 7, 2025 17:20
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
@kellyguo11 kellyguo11 changed the title Added improved readout from install_deps.py Adds improved readout from install_deps.py Aug 8, 2025
@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Test Results Summary

2 419 tests   2 011 ✅  2h 18m 52s ⏱️
   90 suites    408 💤
    1 files        0 ❌

Results for commit 3e9d0b2.

@ooctipus
ooctipus merged commit 538b649 into main Aug 8, 2025
@ooctipus
ooctipus deleted the hhansen/improve_install_deps_readout branch August 8, 2025 03:53
StephenWelch pushed a commit to StephenWelch/IsaacLab that referenced this pull request Aug 17, 2025
# Description
This adds improved readout from the subprocesses in `install_deps.py`.
It will now print the output instead of printing everything at once when
the process is finished. It also has improved error handling. This will
help users to have a better understanding of their build process and
more easily resolve issues.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------

Signed-off-by: Hunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kelly Guo <kellyg@nvidia.com>
george-nehma pushed a commit to george-nehma/DreamLander-IsaacLab that referenced this pull request Oct 24, 2025
# Description
This adds improved readout from the subprocesses in `install_deps.py`.
It will now print the output instead of printing everything at once when
the process is finished. It also has improved error handling. This will
help users to have a better understanding of their build process and
more easily resolve issues.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------

Signed-off-by: Hunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kelly Guo <kellyg@nvidia.com>
LJones-alt pushed a commit to LJones-alt/IsaacLab-Laura that referenced this pull request Jul 1, 2026
# Description
This adds improved readout from the subprocesses in `install_deps.py`.
It will now print the output instead of printing everything at once when
the process is finished. It also has improved error handling. This will
help users to have a better understanding of their build process and
more easily resolve issues.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------

Signed-off-by: Hunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kelly Guo <kellyg@nvidia.com>
csj-275 pushed a commit to csj-275/IsaacLab that referenced this pull request Jul 8, 2026
# Description
This adds improved readout from the subprocesses in `install_deps.py`.
It will now print the output instead of printing everything at once when
the process is finished. It also has improved error handling. This will
help users to have a better understanding of their build process and
more easily resolve issues.

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------

Signed-off-by: Hunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kelly Guo <kellyg@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants