Repository navigation
Don't include files list DatasetInfo (and remove old stuff) - #8128
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
harupy
added a commit
to harupy/mlflow
that referenced
this pull request
May 12, 2026
`datasets` 4.8.5 stopped populating `DatasetInfo.download_checksums` (huggingface/datasets#8128), so the revision assertion in `test_from_huggingface_dataset_constructs_expected_dataset_with_revision` trips on `None`. Switch the canonical revision check to `mlflow_ds_new.source.revision`, and keep the checksum check only when the field is still populated. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
added a commit
to harupy/mlflow
that referenced
this pull request
May 12, 2026
`datasets` 4.8.5 stopped populating `DatasetInfo.download_checksums` (huggingface/datasets#8128), so the revision assertion in `test_from_huggingface_dataset_constructs_expected_dataset_with_revision` trips on `None`. Switch the canonical revision check to `mlflow_ds_new.source.revision`, and keep the checksum check only when the field is still populated. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
7 of 8 tasks
Closed
2 of 7 tasks
DaoDaoNoCode
added a commit
to DaoDaoNoCode/mlflow
that referenced
this pull request
May 15, 2026
datasets 4.8.5 stopped populating DatasetInfo.download_checksums (huggingface/datasets#8128), so the revision assertion trips on None with a TypeError. Switch the revision check to mlflow_ds_new.source.revision, which is the canonical source of truth and equally captures the intent of the assertion. Cherry-picked from mlflow/mlflow@87182fb Signed-off-by: Juntao Wang <juntwang@redhat.com>
This was referenced May 15, 2026
Closed
DaoDaoNoCode
added a commit
to DaoDaoNoCode/mlflow
that referenced
this pull request
May 15, 2026
datasets 4.8.5 stopped populating DatasetInfo.download_checksums (huggingface/datasets#8128), so the revision assertion trips on None with a TypeError. Switch the revision check to mlflow_ds_new.source.revision, which is the canonical source of truth and equally captures the intent of the assertion. Cherry-picked from mlflow/mlflow@87182fb (mlflow#23228) Signed-off-by: Juntao Wang <juntwang@redhat.com>
mprahl
pushed a commit
to opendatahub-io/mlflow
that referenced
this pull request
May 15, 2026
datasets 4.8.5 stopped populating DatasetInfo.download_checksums (huggingface/datasets#8128), so the revision assertion trips on None with a TypeError. Switch the revision check to mlflow_ds_new.source.revision, which is the canonical source of truth and equally captures the intent of the assertion. Cherry-picked from mlflow/mlflow@87182fb (mlflow#23228) Signed-off-by: Juntao Wang <juntwang@redhat.com>
Elsword016
pushed a commit
to Elsword016/datasets
that referenced
this pull request
Aug 6, 2026
âĶace#8128) don't include files list in fo and remove old stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will fix the viewer when it saves the dataset info in mongo, for datasets with a lot of files this can make the mongo doc too big for mongo
I also removed old deprecated stuff linked to files list like the old concept of "post-processing" and cleaned the checksum recording logic