Skip to content

fix: add num_proc argument to Dataset.to_sql - #7791

Merged
lhoestq merged 3 commits into
huggingface:mainfrom
EricSaikali:main
May 4, 2026
Merged

lhoestq merged 3 commits into
huggingface:mainfrom
EricSaikali:main

Conversation

@EricSaikali

@EricSaikali EricSaikali commented Sep 25, 2025 •

Copy link
Copy Markdown
Contributor

Task Done:

@lhoestq

lhoestq commented Oct 6, 2025

Copy link
Copy Markdown
Member

Hi ! could you also write a test to make sure this works fine ?

(in case there needs to be a special logic to handle the concurrent writes to the database)

@EricSaikali

Copy link
Copy Markdown
Contributor Author

Hi @lhoestq
Done! Let me know if more is needed :)

@EricSaikali

EricSaikali commented Nov 7, 2025 •

Copy link
Copy Markdown
Contributor Author

Hi @lhoestq could you please review my changes?

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lhoestq lhoestq left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! and sorry for the delay

@lhoestq
lhoestq merged commit aa24915 into huggingface:main May 4, 2026
6 of 14 checks passed
Elsword016 pushed a commit to Elsword016/datasets that referenced this pull request Aug 6, 2026
* chore: add `num_proc` argument to `Dataset.to_sql`

* test: add test with `num_proc` for `to_sql` function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants