Repository navigation
fix: add num_proc argument to Dataset.to_sql - #7791
Merged
Merged
Conversation
Member
|
Hi ! could you also write a test to make sure this works fine ? (in case there needs to be a special logic to handle the concurrent writes to the database) |
Contributor
Author
|
Hi @lhoestq |
Contributor
Author
|
Hi @lhoestq could you please review my changes? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lhoestq
approved these changes
May 4, 2026
Elsword016
pushed a commit
to Elsword016/datasets
that referenced
this pull request
Aug 6, 2026
* chore: add `num_proc` argument to `Dataset.to_sql` * test: add test with `num_proc` for `to_sql` function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Done:
Dataset.to_sqldoesn't utilizenum_proc #7788 : Add the missing argument mapping in Dataset.to_sql (src/datasets/arrow_dataset.py)