Skip to content

Add note clarifying feature availability - #11822

Merged
lecoursen merged 4 commits into
github:mainfrom
Maximisch:patch-2
Nov 12, 2021
Merged

lecoursen merged 4 commits into
github:mainfrom
Maximisch:patch-2

Conversation

@Maximisch

@Maximisch Maximisch commented Nov 10, 2021 •

Copy link
Copy Markdown
Contributor

Why:

Minor adjustment to make feature availability more clear for customers.
People are currently frustrated that this feature cannot be activated for private repositories only (see e.g. here), and this minor note should help avoid future frustration.

What's being changed:

Added the sentence "Issue forms can currently be enabled on private repositories only." to the note box on issue forms.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome

welcome Bot commented Nov 10, 2021

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Nov 10, 2021
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 10, 2021
@ramyaparimi

Copy link
Copy Markdown
Contributor

@Maximisch
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@lecoursen lecoursen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 @Maximisch, I agree that this would be helpful to clarify! While reviewing this I noticed that "Syntax for issue forms" seems to be repeating this beta information twice:

image

Adding the new information to the reusable here would lead to even more duplication. 😭 Would you mind removing that product property from the front matter of that article in this PR as well? Thanks!

@github-actions

github-actions Bot commented Nov 12, 2021 •

Copy link
Copy Markdown
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms.md Modified Original

@Maximisch

Copy link
Copy Markdown
Contributor Author

@lecoursen I removed the product tag as you suggested! 👍

@Maximisch
Maximisch requested a review from lecoursen November 12, 2021 12:09
@lecoursen
lecoursen enabled auto-merge November 12, 2021 13:08
@lecoursen
lecoursen merged commit bc33c8d into github:main Nov 12, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants