OTP-20270 - #11545
Merged
Merged
Conversation
"Content-Length : 6" (space before colon) was silently dropped by
key_value/1, causing content-length to default to "0". The orphaned
body bytes were then reinterpreted as the next pipelined request via
body_data/2, enabling CL.0 request smuggling/desync.
RFC 7230 Section 3.2.4 states that no whitespace is allowed between
the header field-name and colon, and such requests must be rejected.
Return {error, whitespace_before_colon} from key_value/1 instead of
undefined for this case. Handle it in parse_headers/7 by returning
{error, {bad_request, 400, _}, Version}.
Contributor
CT Test ResultsTests are running... https://github.com/erlang/otp/actions/runs/33105810132 Results for commit 4eff6a5 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Whaileee
force-pushed
the
whaileee/OTP-20270
branch
from
September 1, 2026 07:37
4eff6a5 to
0067225
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.