[BUGFIX LTS] Don't run getters while applying mixins - #20388
Merged
Conversation
This change ensures that getters are never evaluated while applying mixins. It relies on the fact that all getters (including undecorated ones) get converted into classic decorators when the mixin is originally created.
Contributor
|
Looks like this is aimed at the issue ID'd in #19916? |
Contributor
|
@chriskrycho It's related to #18860 and #20129 |
Contributor
Member
Author
|
@chriskrycho Do you mean to refer to "No documented public API for |
Contributor
|
Nope, brain fog. I meant #18860, which Krystan linked. ðŪâðĻ |
chriskrycho
suggested changes
Mar 4, 2023
chriskrycho
left a comment
chriskrycho
left a comment
Contributor
There was a problem hiding this comment.
Couple small things and then we should be able to land and back port this. Thanks for getting it fixed!
Co-authored-by: Chris Krycho <hello@chriskrycho.com>
Contributor
|
@chriskrycho I think this is ready |
chriskrycho
approved these changes
Mar 8, 2023
Contributor
|
I am planning to do an LTS release (so: back to 4.8) by the end of this week and will make sure this is included! |
This was referenced Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that getters are never evaluated while applying
mixins.
It relies on the fact that all getters (including undecorated ones) get
converted into classic decorators when the mixin is originally created.