Skip to content

Add JFR NetworkUtilization event support - #23913

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
thallium:jfr-net-util
May 26, 2026
Merged

Add JFR NetworkUtilization event support#23913
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
thallium:jfr-net-util

Conversation

@thallium

Copy link
Copy Markdown
Contributor

No description provided.

@thallium

Copy link
Copy Markdown
Contributor Author

@tajila FYI

Comment thread runtime/oti/j9nonbuilder.h Outdated
Comment thread runtime/vm/jfr.cpp Outdated
Comment thread runtime/vm/jfr.cpp Outdated
Comment thread runtime/vm/jfr.cpp Outdated
Comment thread runtime/vm/jfr.cpp Outdated
Comment thread runtime/vm/JFRConstantPoolTypes.cpp Outdated
Comment thread runtime/vm/JFRConstantPoolTypes.cpp Outdated
@tajila

tajila commented May 19, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity.functional xlinux jdk17

Comment thread runtime/vm/jfr.cpp Outdated
Comment thread runtime/vm/JFRChunkWriter.cpp Outdated
Comment thread runtime/vm/JFRConstantPoolTypes.cpp Outdated
Comment thread runtime/vm/JFRConstantPoolTypes.hpp Outdated
@thallium
thallium force-pushed the jfr-net-util branch 3 times, most recently from 998e2a2 to 1a22d16 Compare May 19, 2026 19:30
Comment thread runtime/vm/JFRChunkWriter.cpp Outdated

@keithc-ca keithc-ca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be tests that validate this new functionality.

@thallium

Copy link
Copy Markdown
Contributor Author

Test has been added.

@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test sanity amac jdk21

@tajila

tajila commented May 21, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity.functional xlinux jdk17

@keithc-ca keithc-ca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New leaks (not mentioned in #22746) appear to be introduced by this change:

         [ERR] Block was allocated by /Users/jenkins/workspace/Build_JDK21_aarch64_mac_Personal/openj9/runtime/vm/JFRConstantPoolTypes.cpp:961

Comment thread runtime/vm/JFRConstantPoolTypes.cpp Outdated
Comment thread runtime/vm/JFRConstantPoolTypes.hpp
Comment thread runtime/vm/JFRConstantPoolTypes.cpp Outdated
Comment thread runtime/vm/JFRConstantPoolTypes.cpp Outdated
Comment thread runtime/vm/JFRConstantPoolTypes.cpp Outdated
Comment thread runtime/vm/JFRConstantPoolTypes.cpp
@keithc-ca

Copy link
Copy Markdown
Contributor

Please rebase to avoid implicit merges (e.g. with #23903).

@tajila

tajila commented May 26, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity.functional xlinux jdk17

@keithc-ca

Copy link
Copy Markdown
Contributor

This still leads to implicit merges of j9nonbuilder.h and jfr.cpp - please rebase.

Build in progress: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/9203.

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
@keithc-ca

Copy link
Copy Markdown
Contributor

Testing passed.

@keithc-ca
keithc-ca merged commit e8a63c5 into eclipse-openj9:master May 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants