Fix Win32 build failure in MethodHandleNatives - #23910
Merged
Merged
Conversation
Contributor
Author
|
fyi @pshipton |
keithc-ca
requested changes
May 14, 2026
Use UDATA for field offsets when resolving MemberName fields. The getJNIFieldID helper expects a UDATA offset and a UDATA* inconsistentData out parameter. Using U_64 for the offset caused a narrowing conversion warning on Win32, which is treated as an error. Fixes: eclipse-openj9#23905 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Contributor
Author
|
@keithc-ca All feedback has been addressed. |
Contributor
|
Jenkins compile win32 jdk8 |
keithc-ca
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use UDATA for field offsets when resolving MemberName fields.
The getJNIFieldID helper expects a UDATA offset and a UDATA*
inconsistentData out parameter. Using U_64 for the offset caused a
narrowing conversion warning on Win32, which is treated as an error.
Fixes: #23905