Skip to content

Update tests to add a sleep before destroying nonpersistent cache - #23881

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
pshipton:nonperdelay
May 12, 2026
Merged

Update tests to add a sleep before destroying nonpersistent cache#23881
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
pshipton:nonperdelay

Conversation

@pshipton

Copy link
Copy Markdown
Member

Issue eclipse-openj9#23288 (comment)

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
pshipton requested a review from keithc-ca May 11, 2026 20:42
<output type="failure" caseSensitive="yes" regex="no">Processing dump event</output>
</test>

<exec command="sleep 0.5" platforms="linux.*" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many other places that destroy caches (some in this file): Why was a delay not added before each of those operations?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only deleting nonpersistent caches which is a problem. I only added the delay in the places that were failing in nightly testing. If I see more failures I can add more sleeps. We don't need to slow down the testing unnecessarily by adding sleeps to places that don't need them.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be other test suites which are failing, but these are two main ones. I'll be looking at other failures in the coming days.

@keithc-ca keithc-ca May 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring specifically to "deleting nonpersistent caches" elsewhere. It's a little disconcerting that we don't appear to understand why those other places don't need to change.

@keithc-ca
keithc-ca merged commit 78c9d52 into eclipse-openj9:master May 12, 2026
3 checks passed
keithc-ca pushed a commit that referenced this pull request May 14, 2026
Fix another failure in testSCCMLSnapshot which occurred once in the last
nightly testing.

Related to #23881

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
dev-koan pushed a commit to dev-koan/openj9 that referenced this pull request May 27, 2026
Fix another failure in testSCCMLSnapshot which occurred once in the last
nightly testing.

Related to eclipse-openj9#23881

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants