Skip to content

Valhalla JVM method signature update - #23740

Merged
hangshao0 merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:valarray
Apr 15, 2026
Merged

Valhalla JVM method signature update#23740
hangshao0 merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:valarray

Conversation

@JasonFengJ9

Copy link
Copy Markdown
Member

Valhalla JVM method signature update

Match the JNIEXPORT signatures in jvm.h and also the upstream updates.

This addresses the compilation failure:

21:31:36  /home/jenkins/workspace/Build_JDKnext_x86-64_linux_valhalla_Nightly/openj9/runtime/j9vm/valhallavmi.cpp:97:1: error: conflicting declaration of C function ‘jboolean JVM_IsFlatArray(JNIEnv*, jobject)’
21:31:36     97 | JVM_IsFlatArray(JNIEnv *env, jobject obj)
21:31:36        | ^~~~~~~~~~~~~~~
21:31:36  In file included from /home/jenkins/workspace/Build_JDKnext_x86-64_linux_valhalla_Nightly/openj9/runtime/j9vm/jvm.h:253,
21:31:36                   from /home/jenkins/workspace/Build_JDKnext_x86-64_linux_valhalla_Nightly/openj9/runtime/j9vm/valhallavmi.cpp:26:
21:31:36  /home/jenkins/workspace/Build_JDKnext_x86-64_linux_valhalla_Nightly/build/linux-x86_64-server-release/vm/runtime/j9vm/generated.h:628:28: note: previous declaration ‘jboolean JVM_IsFlatArray(JNIEnv*, jclass)’
21:31:36    628 | JNIEXPORT jboolean JNICALL JVM_IsFlatArray(JNIEnv *env, jclass cls);
21:31:36        |                            ^~~~~~~~~~~~~~~
21:31:36  gmake[6]: *** [runtime/j9vm/CMakeFiles/jvm.dir/valhallavmi.cpp.o] Error 1

Verified via a personal build

Signed-off-by: Jason Feng fengj@ca.ibm.com

Match the JNIEXPORT signatures in jvm.h and also the upstream updates.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9 JasonFengJ9 added comp:vm project:valhalla Used to track Project Valhalla related work labels Apr 15, 2026
@JasonFengJ9
JasonFengJ9 requested a review from hangshao0 April 15, 2026 13:59

@hangshao0 hangshao0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangshao0
hangshao0 merged commit 58dbe5f into eclipse-openj9:master Apr 15, 2026
3 checks passed
@JasonFengJ9
JasonFengJ9 deleted the valarray branch April 15, 2026 15:20
@github-project-automation github-project-automation Bot moved this from TODO: VM to Done in Valhalla L-World Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:vm project:valhalla Used to track Project Valhalla related work

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants