Skip to content

Partially Revert "Stabilize ExceptionMeta profiling by using preserved copy" - #23563

Merged
r30shah merged 1 commit into
eclipse-openj9:masterfrom
a7ehuo:fix-pr23447-jprofilingvalue
Mar 25, 2026
Merged

Partially Revert "Stabilize ExceptionMeta profiling by using preserved copy"#23563
r30shah merged 1 commit into
eclipse-openj9:masterfrom
a7ehuo:fix-pr23447-jprofilingvalue

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

This partially reverts commit PR #23447 15c211e.

Utilizing the existing mechanism in addProfilingTrees to find the temp or the register that stores ExceptionMeta. If not found, store it to a temp slot as implemented in PR #23447 15c211e.

…d copy"

This partially reverts commit PR eclipse-openj9#23447 15c211e.

Utilizing the existing mechanism in addProfilingTrees to find the
temp or the register that stores ExceptionMeta. If not found, store
it to a temp slot as implemented in PR eclipse-openj9#23447 15c211e.
@a7ehuo
a7ehuo requested a review from r30shah March 23, 2026 14:22
@a7ehuo

a7ehuo commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

@r30shah May I ask you to review this change? Thank you!

@r30shah

r30shah commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity all jdk21,jdk25

@r30shah r30shah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r30shah

r30shah commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity xlinux jdk21,jdk25

@a7ehuo

a7ehuo commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

Build_JDK25_x86-64_linux_Personal failed: due to infrastructure issue [1].

Test_openjdk25_j9_sanity.openjdk_x86-64_mac_Personal
jdk_lang_j9_0/1 failed: similar to #11430 [2]

[1]

23:03:23  gzip: stdout: No space left on device
23:13:15  wrapper script does not seem to be touching the log file in /home/jenkins/workspace/Build_JDK25_x86-64_linux_Personal@tmp/durable-078683e5
23:13:15  (JENKINS-48300: if on an extremely laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=86400)
23:13:15  cent9-x86-3 seems to be removed or offline (java.io.IOException: No space left on device); will wait for 5 min 0 sec for it to come back online

[2]

2026-03-23T15:35:21.518Z]   LANG=en_US.UTF-8
[2026-03-23T15:35:21.518Z] ++++Test Output++++
[2026-03-23T15:35:21.518Z]   Expected file.encoding: UTF-8
[2026-03-23T15:35:21.518Z]   Actual file.encoding: US-ASCII
[2026-03-23T15:35:21.518Z]   Expected sun.jnu.encoding is "skip", ignoring
[2026-03-23T15:35:21.518Z]   Exception in thread "main" java.lang.RuntimeException: Test Failed
[2026-03-23T15:35:21.518Z]   	at ExpectedEncoding.main(ExpectedEncoding.java:63)
...
[2026-03-23T15:52:03.363Z] -----------------------------------
[2026-03-23T15:52:03.363Z] jdk_lang_j9_0_FAILED
[2026-03-23T15:52:03.363Z] -----------------------------------

@r30shah

r30shah commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity xlinux jdk25

@r30shah

r30shah commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity xmac jdk25

@r30shah

r30shah commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

jenkins test sanity xlinux jdk25

@r30shah r30shah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test passed. Merging this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants