OpenJ9 changes for JIT Logger refactoring - #23463
Conversation
1022e68 to
6183df4
Compare
|
Jenkins test sanity.functional,sanity.openjdk xlinux,alinux,zlinux,plinux jdk17 depends eclipse-omr/omr#8152 |
|
Despite the suspiciously similar name, the Power failure is #13875 and has nothing to do with JIT Loggers. |
6183df4 to
7c77531
Compare
|
@dsouzai : may I ask you to take the lead on reviewing this PR please? It will require a coordinated merge with eclipse-omr/omr#8152 when the time comes. @mpirvu : may I ask you to look at the JitServer changes? I had to introduce a "read" capability into the Logger API to accommodate the way JitServer captures and sends the log file across the wire. I've tested this manually on a few log files to be sure it works, but I'd appreciate a review from you on at least the JitServer parts. Thank you both. |
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
* Use OMR::Options::buildLogFileName() in place of bespoke formatting * Remove FrontEnd name formatting functionality * Support OMR option and identifier renames Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Ensure port library versions are invoked if required. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
7c77531 to
49a5317
Compare
|
Jenkins test sanity.functional xlinux,alinux,zlinux,plinux jdk17 depends eclipse-omr/omr#8152 |
1 similar comment
|
Jenkins test sanity.functional xlinux,alinux,zlinux,plinux jdk17 depends eclipse-omr/omr#8152 |
|
@mpirvu review reminder ping. |
|
@0xdaryl (once testing completes) I think we can go ahead with merging. However, I'll wait until you unmark the WIP. |
Thanks for the review. I am just completing some manual testing on Power and Z before un-WIPing. |
0xdaryl
changed the title
|
Un-WIPed. |
3 participants
These are the downstream OpenJ9 changes required to support the
Logger infrastructure refactoring in eclipse-omr/omr#8152.
The bulk of the documentation and rationale can be found in the OMR PR.
To simplify delivery of these changes, this PR has a breaking dependency on
eclipse-omr/omr#8152 and requires a coordinated merge.