(0.55) Avoid crash in fillInStackTrace when threadObject is null - #22405
Merged
Conversation
Add a null check for _currentThread->threadObject in inlThrowableFillInStackTrace to prevent a crash during early JVM startup. When J9_EXTENDED_RUNTIME2_SHOW_CARRIER_FRAMES is enabled, continuation stack walking is triggered to collect carrier frames. This requires a valid threadObject, which may be uninitialized during early exceptions (e.g., during Unsafe.registerNatives). Without the check, a null dereference can occur when calling IS_JAVA_LANG_VIRTUALTHREAD. This fix ensures stack walking is only attempted when threadObject is set, preventing segmentation faults during JVM initialization. Related: eclipse-openj9#21734 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
pshipton
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a null check for
_currentThread->threadObjectininlThrowableFillInStackTraceto prevent a crash during early JVMstartup.
When
J9_EXTENDED_RUNTIME2_SHOW_CARRIER_FRAMESis enabled,continuation stack walking is triggered to collect carrier frames. This requires
a valid
threadObject, which may be uninitialized during early exceptions(e.g., during
Unsafe.registerNatives). Without the check, anulldereference can occur when calling
IS_JAVA_LANG_VIRTUALTHREAD.This fix ensures stack walking is only attempted when
threadObjectisset, preventing segmentation faults during JVM initialization.
Related: #21734
Backport of #22382