(0.54) Z: disable iTable check in jit - #22347
Merged
pshipton merged 1 commit intoJul 31, 2025
Merged
Conversation
We populate the IPIC slots on helper call. When checking iTable entries in jit, we don't use helper therefore IPIC slots never get populated. Since PIC slots are fastest method of finding the implementation, this is causing some regression. Disabling iTable cache until we can populate PIC slots. Backport of: eclipse-openj9#22330 signed-off-by: Ehsan Kiani Far <ehsan.kianifar@gmail.com>
ehsankianifar
force-pushed
the
Z_disableITableEntryCheckInJit
branch
from
July 31, 2025 20:36
e0e6882 to
ecb7abe
Compare
Contributor
Author
|
@r30shah opened this PR for release. |
Contributor
|
@pshipton We do not intend to jeopardize JDK24 effort, but one of the regression we are seeing internally is fixed by disabling the codegen opt in this PR. Would appreciate if you merge or close the PR. |
pshipton
changed the title
pshipton
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We populate the IPIC slots on helper call. When checking iTable entries in jit, we don't use helper therefore IPIC slots never get populated. Since PIC slots are fastest method of finding the implementation, this is causing some regression.
Disabling iTable cache until we can populate PIC slots.
Port #22330