Skip to content

RAM Class Persistence: Remove redundant call to initializeSnapshotClassObject - #22214

Merged
tajila merged 1 commit into
eclipse-openj9:masterfrom
lzhou2025:frozenClassV2
Jul 14, 2025
Merged

RAM Class Persistence: Remove redundant call to initializeSnapshotClassObject#22214
tajila merged 1 commit into
eclipse-openj9:masterfrom
lzhou2025:frozenClassV2

Conversation

@lzhou2025

@lzhou2025 lzhou2025 commented Jul 11, 2025

Copy link
Copy Markdown
Member

The initialization of classObject of J9Class is done by
loadWarmClassFromSnapshot() and make initializeSnapshotClassObject()
redundant. Other modification includes if the call is failed, go to
exit or error processing.

Fixes: #22201

@lzhou2025 lzhou2025 changed the title Fix duplicte codes Fix redundant codes Jul 11, 2025
@keithc-ca
keithc-ca requested a review from tajila July 11, 2025 15:21
@tajila

tajila commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

@lzhou2025 Please modify the title of the PR to reflect the nature of the change. Perhaps something like "RCP: Remove redundant class object allocation"

@tajila

tajila commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

or "Remove redundant call to initializeSnapshotClassObject"

@lzhou2025 lzhou2025 changed the title Fix redundant codes RAM Class Persistence: Remove redundant call to initializeSnapshotClassObject Jul 11, 2025
The initialization of classObject of J9Class is done by
loadWarmClassFromSnapshot() and make initializeSnapshotClassObject()
redundant. Other modification includes if the call is failed, go to
exit or error processing.

Fixes: eclipse-openj9#22201
@lzhou2025
lzhou2025 marked this pull request as ready for review July 11, 2025 17:12
@tajila

tajila commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

jenkins compile alinux64 jdk17

@tajila
tajila merged commit 22de641 into eclipse-openj9:master Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RCP: ASSERTION FAILED in classObject is NULL

2 participants