Cleanup ObjectCheck - #20467
Merged
Merged
Conversation
Update ObjectCheck.cpp and ObjecrCheck.hpp according Coding Standards: - use correct variable types - fix code formatting - replace extensions to ext Signed-off-by: Dmitri Pivkine <Dmitri_Pivkine@ca.ibm.com>
Contributor
Author
|
fixes #20468 |
amicic
reviewed
Oct 31, 2024
|
|
||
| /* check alignment */ | ||
| if (0 != ((UDATA)ptr & (sizeof(UDATA) - 1))) { | ||
| if (0 != ((uintptr_t)ptr & (sizeof(uintptr_t) - 1))) { |
Contributor
There was a problem hiding this comment.
while we can keep this change minimalistic (formatting only), we should probably use a proper const/variable rather then sizeof(uintptr_t)
we objectAlignmentInBytes available at a few places
although I'm a bit confused - ptr is pointer to RAM class, should we not have a strong check for 256 byte (for what we have J9_REQUIRED_CLASS_ALIGNMENT)!?
Contributor
Author
There was a problem hiding this comment.
Yes, it caught my eye too, we need to check correctness as well is this code in use or obsolete. I added this to my todo list. I think it is better to keep this PR formatting only.
Regarding sizeof(uintptr_t) I thought about this too. Do we have a better declaration?
Contributor
|
jenkins compile win,aix jdk21 |
amicic
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ObjectCheck.cpp and ObjecrCheck.hpp according Coding Standards: