Remove method TR_J9VMBase::findOrCreateClassAndDepthFlagsSymbolRef - #20397
Conversation
A method named findOrCreateClassDepthAndFlagsSymbolRef was introduced to TR_J9VMBase by a previous commit to correct the typo in the name of the method, findOrCreateClassAndDepthFlagsSymbolRef. That change kept the old method due to upstream uses in J9_PROJECT_SPECIFIC code in OMR. This change replaces a call to findOrCreateClassAndDepthFlagsSymbolRef that was recently introduced with a call to TR_J9VMBase::testIsClassArrayType instead, to hide the manipulation of the classDepthAndFlags field. As that was the last remaining use of findOrCreateClassAndDepthFlagsSymbolRef, this change also removes the now obsolete method from TR_J9VMBase. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
|
As this changes code that is guarded by |
|
This pull request follows on from pull request #19558 which first introduced The functional part of the change is guarded by the preprocessor directive As that would not be tested by regular PR testing, I ran an internal personal build with the help of @rmnattas who verified that there didn't seem to be any unexpected failures, and that the IL that was generated with this change appeared to be correct. @0xdaryl, @rmnattas, may I ask you both to review this change? |
|
Jenkins test sanity all jdk21 |
0xdaryl
left a comment
0xdaryl
left a comment
There was a problem hiding this comment.
The x86 Linux tests appear to have passed even though the status in the PR isn't updated. The Z Linux failure does not appear to be one that could be caused by this PR, and has appeared intermittently for several years. I will merge this.
3 participants
A method named
findOrCreateClassDepthAndFlagsSymbolRefwas introduced toTR_J9VMBaseby a previous commit to correct the typo in the name of the method,findOrCreateClassAndDepthFlagsSymbolRef. That change kept the old method due to upstream uses inJ9_PROJECT_SPECIFICcode in OMR.This change replaces a call to
findOrCreateClassAndDepthFlagsSymbolRefthat was recently introduced with a call toTR_J9VMBase::testIsClassArrayTypeinstead, to hide the manipulation of theclassDepthAndFlagsfield.As that was the last remaining use of
findOrCreateClassAndDepthFlagsSymbolRef, this change also removes the now obsolete method fromTR_J9VMBase.This is follow on to pull request #19558 which first introduced
TR_J9VMBase::findOrCreateClassDepthAndFlagsSymbolRefto replaceTR_J9VMBase::findOrCreateClassAndDepthFlagsSymbolRef.