Adjust IProfiler locked entry assert - #20375
Merged
Merged
Conversation
Contributor
Author
|
Attn @mpirvu. I believe this addresses the scenario I outlined in #20344 (comment), but it's very difficult to test. |
mpirvu
approved these changes
Oct 21, 2024
mpirvu
left a comment
mpirvu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just a small suggestion for a comment.
|
|
||
| TR_IPMethodHashTableEntry *findOrCreateMethodEntry(J9Method *, J9Method *, bool addIt, uint32_t pcIndex = ~0); | ||
| uint32_t releaseAllEntries(); | ||
| // Returns the number of entries released, and also adds the number of |
Contributor
There was a problem hiding this comment.
Suggestion: "// Returns the number of entries released, and also stores the number of"
mpirvu
approved these changes
Oct 21, 2024
The TR_IProfiler::releaseAllEntries() function is used with DEBUG to check that all entries in the IProfiler _bcHashTable are unlocked at JVM exit. This function now compensates for a known race condition in TR_IProfiler::findOrCreateEntry() by also reporting the number of locked entries it encounters that were likely not a result of that race condition, so it can be asserted instead that that total is zero. Signed-off-by: Christian Despres <despresc@ibm.com>
cjjdespres
force-pushed
the
adjust-iprofiler-assert
branch
from
October 24, 2024 14:03
f5b11d3 to
134ccd9
Compare
Contributor
|
jenkins test sanity xlinuxjit,zlinuxjit,alinux64jit jdk21 |
Contributor
|
zlinuxjit encountered a timeout in |
Contributor
|
Since the new code only affects debug builds, it could not have caused the issue seen in testing. Hence, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TR_IProfiler::releaseAllEntries() function is used with DEBUG to check that all entries in the IProfiler _bcHashTable are unlocked at JVM exit. This function now compensates for a known race condition in TR_IProfiler::findOrCreateEntry() by also reporting the number of locked entries it encounters that were likely not a result of that race condition, so it can be asserted instead that that total is zero.
Fixes: #20344