Fix retrieval of switch IProfiler info from SCC - #20348
Merged
Merged
Conversation
The code that retrieves IProfiler info from the shared class cache (SCC) first does a check to see whether the data stored is valid. This check is done against `entry->getData()`, but for switches this always returns 0. As a consequence the JVM is never able to retrieve switch IProfiler data from SCC. This commit adds a new virtual call, `hasData()`, which will be tested instead of `getData()`. The reason we cannot use `getData()` directly, is that the switch data uses 32 bytes, exceeding the size returned by getData() which is only 8 bytes (for 64-bit architectures). Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
dsouzai
approved these changes
Oct 15, 2024
Contributor
|
jenkins test sanity xlinux jdk17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that retrieves IProfiler info from the shared class cache (SCC) first does a check to see whether the data stored is valid. This check is done against
entry->getData(), but for switches this always returns 0. As a consequence the JVM is never able to retrieve switch IProfiler data from SCC.This commit adds a new virtual call,
hasData(), which will be tested instead ofgetData().The reason we cannot use
getData()directly, is that the switch data uses 32 bytes, exceeding the size returned bygetData()which is only 8 bytes (for 64-bit architectures).