Return NULL from getStackTraceForThread for unsteady virtual threads - #20306
Merged
Conversation
If inspectorCount is -1, then the virtual thread is in an unsteady state (mounting or unmounting). In such cases, NULL should be returned and the JCL code should retry in order to avoid unexpected behavior. Related: eclipse-openj9#18910 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
marked this pull request as ready for review
October 7, 2024 14:07
Contributor
Author
|
jenkins test sanity.functional,sanity.openjdk xmac,amac,zlinux jdk23 |
Contributor
Author
|
jenkins test sanity.functional,sanity.openjdk xmac jdk21 |
Contributor
Author
|
@tajila Requesting your review. A 250x grinder has passed along with internal personal builds. Further, the PR builds have also passed. |
tajila
approved these changes
Oct 7, 2024
Contributor
|
please make a 0.48 PR |
Contributor
Author
|
0.48 PR: #20313. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
inspectorCountis-1, then the virtual thread is in an unsteadystate (mounting or unmounting). In such cases,
NULLshould be returnedand the JCL code should retry in order to avoid unexpected behavior.
Related: #18910