Add libs for OpenXL compiler on AIX - #20299
Conversation
This commit adds necessary libraries nedded by linker commands for openxl compiler on AIX architechture. Signed-off-by: Ishita Ray <ishita.ray@ibm.com>
zl-wang
left a comment
zl-wang
left a comment
There was a problem hiding this comment.
as stage 1 of OpenXL change, this is safe to do (before we can switch to using OpenXL).
|
jenkins test sanity aix jdk21 |
| j9stackmap | ||
| j9pool | ||
| j9hookable | ||
| if(DEFINED OMR_OS_AIX AND DEFINED CMAKE_C_COMPILER_IS_OPENXL) |
There was a problem hiding this comment.
I don't think the set of libraries should be conditional. If they're necessary for any toolchain, the dependencies should be applied to all.
There was a problem hiding this comment.
I just want to understand clearly, by all you mean all platforms? I never tested this config for zos, so to be safe I am adding them only for AIX platform.
There was a problem hiding this comment.
If the code actually depends on names available only in the libraries that were added for OpenXL, then I expect it was just wrong to omit them in the first place. Adding them only for OpenXL just continues the error. Of course, we would have to verify that the changes don't break other platforms, but I think the risk of that is very low.
3 participants
Adds necessary libraries nedded by
linker commands for openxl compiler on AIX architechture.