Skip to content

Tag test.fil file as binary - #20210

Merged
pshipton merged 1 commit into
eclipse-openj9:masterfrom
psoujany:tag_fil_files
Sep 23, 2024
Merged

Tag test.fil file as binary#20210
pshipton merged 1 commit into
eclipse-openj9:masterfrom
psoujany:tag_fil_files

Conversation

@psoujany

@psoujany psoujany commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

@psoujany

psoujany commented Sep 23, 2024

Copy link
Copy Markdown
Contributor Author

Without tagging the .fil, test fails as below on z/OS.

Running command: "/home/jenkins/workspace/Grinder_CR/jdkbinary/j2sdk-image/bin/java"  -Xjit -Xgcpolicy:gencon -Xnocompressedrefs  -Xdump    -agentlib:jvmtitest=test:abcl001,args:/home/jenkins/workspace/Grinder_CR/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/jvmtitests/jars/test.fil -cp "/home/jenkins/workspace/Grinder_CR/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/jvmtitests/jvmtitest.jar" com.ibm.jvmti.tests.util.TestRunner
18:16:01  Time spent starting: 9 milliseconds
18:16:02  Time spent executing: 1048 milliseconds
18:16:02  Test result: FAILED
18:16:02  Output from test:
18:16:02   [OUT] *** Testing [1/1]:	testAddToBootpathDuringOnload
18:16:02   [OUT] *** Test took 28 milliseconds
18:16:02   [OUT] FAILED
18:16:02   [OUT] 
18:16:02   [ERR] Unable to load class TestClass in null
18:16:02   [ERR] java.lang.ClassNotFoundException: TestClass

@pshipton

Copy link
Copy Markdown
Member

Pls fix the commit title and description. This doesn't tag .fil files, it only tags test/functional/cmdLineTests/jvmtitests/jars/test.fil.

@psoujany psoujany changed the title Tag .fil files as binary Tag test.fil file as binary Sep 23, 2024
@pshipton

Copy link
Copy Markdown
Member

In case it's unclear, the commit itself needs to be reworded, since the title is "Tag .fil files as binary".
Also the description of the PR should be updated from "This PR tags .fil files as binary. Below tests will pass only when .fil files are tagged as binary".

Signed-off-by: Pasam Soujanya <psoujany@in.ibm.com>
@psoujany

Copy link
Copy Markdown
Contributor Author

@pshipton Could you please check if the commit and description is clear now?

@pshipton
pshipton merged commit b70b59d into eclipse-openj9:master Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants