Tag test.fil file as binary - #20210
Merged
Merged
Conversation
Contributor
Author
|
Without tagging the .fil, test fails as below on z/OS. |
Member
|
Pls fix the commit title and description. This doesn't tag .fil files, it only tags |
Member
|
In case it's unclear, the commit itself needs to be reworded, since the title is "Tag .fil files as binary". |
Signed-off-by: Pasam Soujanya <psoujany@in.ibm.com>
psoujany
force-pushed
the
tag_fil_files
branch
from
September 23, 2024 13:52
ece7dd2 to
c626847
Compare
Contributor
Author
|
@pshipton Could you please check if the commit and description is clear now? |
pshipton
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tags below file as binary
https://github.com/eclipse-openj9/openj9/blob/master/test/functional/cmdLineTests/jvmtitests/jars/test.fil