Add JVMInformation support for JFR - #19974
Merged
Merged
Conversation
Contributor
Author
|
@tajila can you please take a look to see if I'm doing anything wrong? |
tajila
reviewed
Aug 8, 2024
Contributor
|
What was the JFR output ? |
Contributor
Author
|
Example output: |
tajila
reviewed
Aug 12, 2024
tajila
reviewed
Aug 12, 2024
tajila
reviewed
Aug 13, 2024
tajila
reviewed
Aug 13, 2024
tajila
reviewed
Aug 13, 2024
tajila
reviewed
Aug 14, 2024
tajila
reviewed
Aug 14, 2024
thallium
force-pushed
the
jvminfo
branch
5 times, most recently
from
August 16, 2024 15:47
505fc01 to
e6fbbf1
Compare
tajila
reviewed
Aug 16, 2024
tajila
reviewed
Aug 16, 2024
Contributor
Author
|
Looks like the Line Ending Check failed because of something else. |
tajila
reviewed
Aug 20, 2024
| jvmInformation->jvmArguments = (char *)j9mem_allocate_memory(sizeof(char) * (vmArgsLen + 1), OMRMEM_CATEGORY_VM); | ||
| char *cursor = jvmInformation->jvmArguments; | ||
|
|
||
| for (UDATA i = 0; i < vmArgs->nOptions; i++) { |
Contributor
There was a problem hiding this comment.
nOptions is signed, you will get warnings when comparing signed vs unsigned
| /* Set JVM arguments by concatenating actualVMArgs */ | ||
| JavaVMInitArgs *vmArgs = vm->vmArgsArray->actualVMArgs; | ||
| UDATA vmArgsLen = vmArgs->nOptions - 1; | ||
| for (UDATA i = 0; i < vmArgs->nOptions; i++) { |
tajila
reviewed
Aug 20, 2024
| * | ||
| * @param vm[in] the J9JavaVM | ||
| */ | ||
| static void initializeJVMInformationEvent(J9JavaVM *vm) |
Contributor
There was a problem hiding this comment.
move this function to JFRConstantPoolTypes into a public static
tajila
reviewed
Aug 20, 2024
tajila
approved these changes
Aug 20, 2024
Contributor
|
jenkins test sanity xlinux jdk17 |
tajila
reviewed
Aug 21, 2024
| jvmInformation->jvmArguments = (char *)j9mem_allocate_memory(sizeof(char) * vmArgsLen, OMRMEM_CATEGORY_VM); | ||
| char *cursor = jvmInformation->jvmArguments; | ||
|
|
||
| for (I_32 i = 0; i < vmArgs->nOptions; i++) { |
Contributor
There was a problem hiding this comment.
one more thing, use IDATA instead
| /* Set JVM arguments by concatenating actualVMArgs */ | ||
| JavaVMInitArgs *vmArgs = vm->vmArgsArray->actualVMArgs; | ||
| UDATA vmArgsLen = vmArgs->nOptions; | ||
| for (I_32 i = 0; i < vmArgs->nOptions; i++) { |
Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
Contributor
|
jenkins Line Endings Check |
Contributor
|
jenkins test sanity xlinux jdk17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.