(0.46)cacheDirPerm should be set if -Xshareclasses is not specified - #19567
Merged
Conversation
SCC is enabled by default when -Xshareclasses is not specified in the CML. cacheDirPerm should be set to J9SH_DIRPERM_ABSENT in this case. Closes eclipse-openj9#19328 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
pshipton
approved these changes
May 28, 2024
Member
|
No point in waiting to merge this since the change was accidentally pushed to v0.46.0-release and this PR doesn't change anything, other than ensure the update will be in the release notes. See #19539 (comment) |
Member
Oh, I see you pushed a revert, I hadn't realized that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCC is enabled by default when -Xshareclasses is not specified in the CML. cacheDirPerm should be set to J9SH_DIRPERM_ABSENT in this case.
Closes #19328